Skip to content

GH Actions: disable all AutoDJ tests on Windows#3368

Merged
uklotzde merged 1 commit intomixxxdj:2.3from
Be-ing:windows_disable_autodj_tests
Nov 24, 2020
Merged

GH Actions: disable all AutoDJ tests on Windows#3368
uklotzde merged 1 commit intomixxxdj:2.3from
Be-ing:windows_disable_autodj_tests

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Nov 24, 2020

Different tests are failing on different builds. I do not know why
they work on Ubuntu and macOS but not Windows.

For example:
https://github.com/mixxxdj/mixxx/runs/1448847307

 The following tests FAILED:
	 10 - AutoDJProcessorTest.FadeAtOutroStart_LongerIntro (Failed)
	 21 - AutoDJProcessorTest.EnabledSuccess_PlayingDeck2_TrackLoadFailed (Failed)

https://github.com/mixxxdj/mixxx/runs/1448857108

The following tests FAILED:
	 10 - AutoDJProcessorTest.FadeAtOutroStart_LongerIntro (Failed)
	 21 - AutoDJProcessorTest.EnabledSuccess_PlayingDeck2_TrackLoadFailed (Failed)

https://github.com/mixxxdj/mixxx/runs/1448901972
This build initially worked, then I manually restarted it to test if clcache works (it does not).

 The following tests FAILED:
	 10 - AutoDJProcessorTest.FadeAtOutroStart_LongerIntro (Failed)

https://github.com/Be-ing/mixxx/runs/1450027225

The following tests FAILED:
	 15 - AutoDJProcessorTest.EnabledSuccess_DecksStopped_TrackLoadFails (Failed)
	 18 - AutoDJProcessorTest.EnabledSuccess_PlayingDeck1_TrackLoadFailed (Failed)

@Be-ing Be-ing force-pushed the windows_disable_autodj_tests branch from c86ff97 to 4b1a02a Compare November 24, 2020 20:39
@Be-ing Be-ing changed the title GH Actions: disable all AutoDJ tests on Windows GH Actions: disable more flapping AutoDJ tests on Windows Nov 24, 2020
@Be-ing Be-ing force-pushed the windows_disable_autodj_tests branch from 4b1a02a to f7039ed Compare November 24, 2020 21:51
@Be-ing Be-ing changed the title GH Actions: disable more flapping AutoDJ tests on Windows GH Actions: disable all AutoDJ tests on Windows Nov 24, 2020
Different tests are failing on different builds. I do not know why
they work on Ubuntu and macOS but not Windows.
@Be-ing Be-ing force-pushed the windows_disable_autodj_tests branch from f7039ed to d8bd0d9 Compare November 24, 2020 21:54
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test (or the code?) can only be analyzed and fixed locally. LGTM

@uklotzde uklotzde merged commit 603a314 into mixxxdj:2.3 Nov 24, 2020
@Be-ing Be-ing deleted the windows_disable_autodj_tests branch November 24, 2020 22:43
@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Nov 24, 2020

These tests weren't failing on AppVeyor or Jenkins though... or were they?

@uklotzde
Copy link
Copy Markdown
Contributor

None that I am aware of. Maybe an issue with VS 2019 vs. VS 2017?

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Nov 24, 2020

That is plausible.

@Holzhaus
Copy link
Copy Markdown
Member

No, these also happened with windows-2016 where VS 2017 is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants