GH Actions: disable all AutoDJ tests on Windows#3368
Merged
uklotzde merged 1 commit intomixxxdj:2.3from Nov 24, 2020
Merged
Conversation
c86ff97 to
4b1a02a
Compare
4b1a02a to
f7039ed
Compare
Different tests are failing on different builds. I do not know why they work on Ubuntu and macOS but not Windows.
f7039ed to
d8bd0d9
Compare
uklotzde
approved these changes
Nov 24, 2020
Contributor
uklotzde
left a comment
There was a problem hiding this comment.
These test (or the code?) can only be analyzed and fixed locally. LGTM
Contributor
Author
|
These tests weren't failing on AppVeyor or Jenkins though... or were they? |
Contributor
|
None that I am aware of. Maybe an issue with VS 2019 vs. VS 2017? |
Contributor
Author
|
That is plausible. |
Member
|
No, these also happened with windows-2016 where VS 2017 is installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different tests are failing on different builds. I do not know why
they work on Ubuntu and macOS but not Windows.
For example:
https://github.com/mixxxdj/mixxx/runs/1448847307
https://github.com/mixxxdj/mixxx/runs/1448857108
https://github.com/mixxxdj/mixxx/runs/1448901972
This build initially worked, then I manually restarted it to test if clcache works (it does not).
https://github.com/Be-ing/mixxx/runs/1450027225