Remove lock from the engine thread.#3282
Merged
uklotzde merged 1 commit intomixxxdj:2.2from Nov 11, 2020
Merged
Conversation
uklotzde
approved these changes
Nov 11, 2020
Contributor
uklotzde
left a comment
uklotzde
left a comment
There was a problem hiding this comment.
m_bypassCueSetByPlay, m_bPreviewing, and m_iCurrentlyPreviewingHotcues are modified in other parts of the code, both locked and unlocked. Since they are also modified in updateIndicators() without locking, removing this lock is at least consistent with the remaining code that is called by the engine thread.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #3268 it is no longer necessary, because the protected code is only run from the main and controller thread.
The order of code ensures that it has no harm.
The mutex mainly protect the cue points and related data structures, these are not touched anyway.
This is considered as a band aid for 2.2 only.
I have a real solution in progress fixing the root cause for 2.3 that has a big impact that does not suit to go into a bugfix release.