Skip to content

WTrackMenu: Add warnings about limitations of lazy iteration#3233

Merged
Holzhaus merged 1 commit into
mixxxdj:2.3from
uklotzde:wtrackmenu_iterator
Oct 28, 2020
Merged

WTrackMenu: Add warnings about limitations of lazy iteration#3233
Holzhaus merged 1 commit into
mixxxdj:2.3from
uklotzde:wtrackmenu_iterator

Conversation

@uklotzde
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde commented Oct 28, 2020

@uklotzde uklotzde added this to the 2.3.0 milestone Oct 28, 2020
@uklotzde uklotzde requested review from daschuer and ronso0 October 28, 2020 23:14
@github-actions github-actions Bot added the ui label Oct 28, 2020
Holzhaus
Holzhaus requested changes Oct 28, 2020
View reviewed changes
Comment thread src/widget/wtrackmenu.h Outdated
Holzhaus
Holzhaus approved these changes Oct 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus Holzhaus merged commit ce2d180 into mixxxdj:2.3 Oct 28, 2020
@uklotzde uklotzde deleted the wtrackmenu_iterator branch October 29, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

@daschuer daschuer Awaiting requested review from daschuer

@ronso0 ronso0 Awaiting requested review from ronso0

Assignees

No one assigned

Labels

code quality ui

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@uklotzde @Holzhaus