ControllerEngine: Re-Enable DEBUG_ASSERTs if --controllerDebug is used#3056
Merged
uklotzde merged 4 commits intomixxxdj:2.3from Sep 1, 2020
Merged
ControllerEngine: Re-Enable DEBUG_ASSERTs if --controllerDebug is used#3056uklotzde merged 4 commits intomixxxdj:2.3from
uklotzde merged 4 commits intomixxxdj:2.3from
Conversation
Holzhaus
force-pushed
the
controller-debug
branch
from
a77b502 to
1918ec2
Compare
Contributor
|
Please merge 2.3 to update (and reduce) the diff of this PR. |
Member
Author
|
Done. |
uklotzde
suggested changes
Aug 31, 2020
uklotzde
approved these changes
Sep 1, 2020
Contributor
|
LGTM |
Contributor
|
@Holzhaus can you take care of merge conflicts with master? |
Member
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3054. Unsure if that is a good idea because you usually shouldn't use assertions to check user input, but this might be helpful when checking controller scripts.