ControlObject/ControlPrivateDouble: Various Fixes#2918
Merged
Holzhaus merged 14 commits intomixxxdj:2.3from Jul 8, 2020
uklotzde:controlobject
Merged
ControlObject/ControlPrivateDouble: Various Fixes#2918Holzhaus merged 14 commits intomixxxdj:2.3from uklotzde:controlobject
Holzhaus merged 14 commits intomixxxdj:2.3from
uklotzde:controlobject
Conversation
7 tasks
daschuer
requested changes
Jul 6, 2020
Contributor
Author
|
All issues addressed. |
Contributor
Author
|
I have re-added the manual deletion of the (parented) SettingsManager, because the logs say so. |
Holzhaus
approved these changes
Jul 7, 2020
Member
Holzhaus
left a comment
Holzhaus
left a comment
There was a problem hiding this comment.
Works fine, no leaked controls anymore.
daschuer
approved these changes
Jul 7, 2020
Member
|
Thank you very much. Waiting for CI. By the way, we have known issue with the m_pCreatorCO. See my inline comment. |
daschuer
reviewed
Jul 7, 2020
Contributor
Author
|
AppVeyor failed to set up the Ubuntu build envionment, unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Urgent fixes that are needed for #2911.