Skip to content

TrackFile/TrackRef are now qHash-able#2761

Merged
uklotzde merged 1 commit into
mixxxdj:masterfrom
xsco:trackref_trackfile_hashable
May 8, 2020
Merged

TrackFile/TrackRef are now qHash-able#2761
uklotzde merged 1 commit into
mixxxdj:masterfrom
xsco:trackref_trackfile_hashable

Conversation

@mr-smidge
Copy link
Copy Markdown
Contributor

This PR adds a qHash() overload for TrackFile and TrackRef, allowing them to be used in QSet etc.

This is a pre-requisite for PR #2753.

@uklotzde
Copy link
Copy Markdown
Contributor

uklotzde commented May 7, 2020

Please fix the end of file newlines: https://travis-ci.org/github/mixxxdj/mixxx/jobs/684309240

@uklotzde uklotzde added this to the 2.4.0 milestone May 7, 2020
@mr-smidge mr-smidge force-pushed the trackref_trackfile_hashable branch from 39eb273 to 0c46121 Compare May 7, 2020 20:53
@mr-smidge mr-smidge marked this pull request as ready for review May 8, 2020 09:31
@uklotzde
Copy link
Copy Markdown
Contributor

uklotzde commented May 8, 2020

LGTM. Thank you!

@uklotzde uklotzde merged commit f2f41d8 into mixxxdj:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants