Skip to content

Knob arcs: add options for reversed paint direction & round caps#2740

Merged
daschuer merged 1 commit intomixxxdj:masterfrom
ronso0:arc-reversed
May 3, 2020
Merged

Knob arcs: add options for reversed paint direction & round caps#2740
daschuer merged 1 commit intomixxxdj:masterfrom
ronso0:arc-reversed

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented May 1, 2020

Final additions to #2275 / #2686

  • <ArcRoundCaps> allows to use a round pen cap for drawing the arc. For regularly sized knobs this will slightly increase visibility of the arc if the knob is just a bit away from the center. For large knobs it's a style tool.
  • <ArcReversed> paints the arc from maxAngle to current position. I will use this for the microphone Ducking knob to communicate the ducking effect. Later on, we can use this for effect knobs like BitCrusher parameters.

Ducking: round cap
Mic Pregain: flat cap
See how the knob and the arc position diverge.
image

@ronso0 ronso0 added the skins label May 1, 2020
@ronso0 ronso0 added this to the 2.3.0 milestone May 1, 2020
Comment thread src/widget/wknobcomposed.cpp Outdated
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented May 1, 2020

Looking at Deere, I think it makes sense to also add a configurable 'center gap' for the background arcs. I guess this will complicate the arc code even more but I think it would be worth it to finalize the arcs for being configured automatically be the connected control later on (center gap, unipolar/bipolar, reversed).

Copy link
Copy Markdown
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 13774dc into mixxxdj:master May 3, 2020
@ronso0 ronso0 deleted the arc-reversed branch May 3, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants