Knob arcs: add options for reversed paint direction & round caps#2740
Merged
daschuer merged 1 commit intomixxxdj:masterfrom May 3, 2020
Merged
Knob arcs: add options for reversed paint direction & round caps#2740daschuer merged 1 commit intomixxxdj:masterfrom
daschuer merged 1 commit intomixxxdj:masterfrom
Conversation
Holzhaus
reviewed
May 1, 2020
Member
Author
|
Looking at Deere, I think it makes sense to also add a configurable 'center gap' for the background arcs. I guess this will complicate the arc code even more but I think it would be worth it to finalize the arcs for being configured automatically be the connected control later on (center gap, unipolar/bipolar, reversed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final additions to #2275 / #2686
<ArcRoundCaps>allows to use a round pen cap for drawing the arc. For regularly sized knobs this will slightly increase visibility of the arc if the knob is just a bit away from the center. For large knobs it's a style tool.<ArcReversed>paints the arc from maxAngle to current position. I will use this for the microphone Ducking knob to communicate the ducking effect. Later on, we can use this for effect knobs like BitCrusher parameters.Ducking: round cap

Mic Pregain: flat cap
See how the knob and the arc position diverge.