Merged
Conversation
Member
Author
|
Let me know when you consider this ready for merge. I'll remove the demo styles then. |
ronso0
commented
Apr 21, 2020
Holzhaus
reviewed
Apr 21, 2020
Member
Holzhaus
left a comment
There was a problem hiding this comment.
Code looks good so far, I'll test this tomorrow.
Holzhaus
reviewed
Apr 22, 2020
Member
Holzhaus
left a comment
There was a problem hiding this comment.
Thank you! Looks great. LGTM (except for the small comments I posted above).
Member
Author
|
Okay, cool. |
Member
|
@ronso0 Ready? |
Member
Author
Yup! |
Draw a bar underneath the slider handle that corresponds represents
the parameter value. New <WSliderComposed> nodes for skin styles:
* BarWidth [double] width of the bar
* BarAxisPos [double] shifts bar center
horizontal: from top
vertial: from left
* BarMargins [int,int] start/end point of bar
horizontal: left, right
vertical: top, bottom
* BarBgMargins [int,int] (optional, adopts BarMargins if empty)
* BarColor [valid hex/rgba/... color]
* BarBgColor [hex/rgba/... color] optional
* BarUnipolar [bool] (default: true)
draw from bottom/left or from center, considering BarMargins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...so that the knob arcs #2686 don't feel so posh :)
Bars can be used alone or in conjunction with slider graphics.
When used alone, experimtent with
<Size>,<BarMargins>to yield a proper (read: tolerant) touch/click-responsive surface.Note: Margins are absolute values, so if you want to use graphics AND dynamic sizes (stretched graphics) it won't work well as of now.
ToDo