Skip to content

Remove unused class WidgetHider#2676

Merged
Be-ing merged 2 commits into
mixxxdj:masterfrom
uklotzde:widgethider
Apr 17, 2020
Merged

Remove unused class WidgetHider#2676
Be-ing merged 2 commits into
mixxxdj:masterfrom
uklotzde:widgethider

Conversation

@uklotzde
Copy link
Copy Markdown
Contributor

Did I miss something? I guess this dead code.

@uklotzde uklotzde added this to the 2.3.0 milestone Apr 17, 2020
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Apr 17, 2020

ripgrep doesn't find anything you missed, this builds and runs, so I guess it was unused legacy code.

@Be-ing Be-ing merged commit e3ab409 into mixxxdj:master Apr 17, 2020
@uklotzde uklotzde deleted the widgethider branch April 17, 2020 20:07
@JosepMaJAZ
Copy link
Copy Markdown
Contributor

Sorry, I didn't see this before.
Yes, that class can be removed.
I added it on 2.0 to improve the recording preferences so that I could dinamically modify the dialog.
After several attemps and migration of Qt, it no longer served a purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants