Skip to content

revert to macOS build environment with Qt 5.12.3#2667

Merged
Be-ing merged 1 commit intomixxxdj:masterfrom
Be-ing:revert_macos_to_qt_5_12_3
Apr 17, 2020
Merged

revert to macOS build environment with Qt 5.12.3#2667
Be-ing merged 1 commit intomixxxdj:masterfrom
Be-ing:revert_macos_to_qt_5_12_3

Conversation

@Be-ing
Copy link
Copy Markdown
Contributor

@Be-ing Be-ing commented Apr 15, 2020

This is a temporary hack for Mixxx 2.3. Upgrading to Qt 5.14.2
caused a major performance regression with the legacy QGLWidgets.
The branch for switching to QOpenGLWidgets (PR #1974) is not yet
ready because of jerking with the waveforms.

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Apr 15, 2020

If we merge this, we need to update https://mixxx.org/wiki/doku.php/compiling_on_os_x to warn against using dependencies from Homebrew until #1974 is merged.

@Holzhaus
Copy link
Copy Markdown
Member

If we merge this, we need to update https://mixxx.org/wiki/doku.php/compiling_on_os_x to warn against using dependencies from Homebrew until #1974 is merged.

Does this mean that OSX users need to compile the old Qt version themselves?

@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Apr 15, 2020

It means if they build locally, they need to use an old version of Qt. They can do that using our prebuilt environment. I think Homebrew can also be used to install specific versions of a package.

This is a temporary hack for Mixxx 2.3. Upgrading to Qt 5.14.2
caused a major performance regression with the legacy QGLWidgets.
The branch for switching to QOpenGLWidgets (PR mixxxdj#1974) is not yet
ready because of jerking with the waveforms.
@Be-ing Be-ing force-pushed the revert_macos_to_qt_5_12_3 branch from 5c4687c to da20301 Compare April 15, 2020 17:14
@uklotzde
Copy link
Copy Markdown
Contributor

On CI we are always using the latest version installed by brew. But since we are using even older Qt versions on Ubuntu this doesn't really matter as long as no one tries to download and execute the build artifacts.

Merge?

@uklotzde uklotzde added the build label Apr 17, 2020
@uklotzde uklotzde added this to the 2.3.0 milestone Apr 17, 2020
@Be-ing
Copy link
Copy Markdown
Contributor Author

Be-ing commented Apr 17, 2020

We should use the same build environment on CI as our build server. But that's an issue for another PR.

@Be-ing Be-ing merged commit de09d85 into mixxxdj:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants