WidgetGroup: add default index0 widget to stacked layout#2646
Merged
daschuer merged 3 commits intomixxxdj:masterfrom May 2, 2020
Merged
WidgetGroup: add default index0 widget to stacked layout#2646daschuer merged 3 commits intomixxxdj:masterfrom
daschuer merged 3 commits intomixxxdj:masterfrom
Conversation
Fixes https://bugs.launchpad.net/mixxx/+bug/1627859 Previously, the first widget in a stacked layout was always visible after skin load regardless of the 'visible' CO value. Adding a zero-sized dummy widget at index 0 here avoids having to do that in skin xml files.
Member
Author
|
Some skin xml workarounds are already removed in #2619 |
daschuer
approved these changes
May 2, 2020
Member
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
LGTM
I have tried to hack around it by restoring the visible state but it fails. So this workaround is the best we have.
Thank you.
Unfortunately this has a merge conflict.
Member
Author
|
Conflicts are fixed. Ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.launchpad.net/mixxx/+bug/1627859
Previously, the first widget in a stacked layout was always visible after skin load regardless of the 'visible' CO value. Adding a zero-sized dummy widget at index 0 here avoids having to do that in
skin xml files.