Skip to content

test/cuecontrol_test: Fix compile error due to missing method#2638

Merged
Be-ing merged 1 commit into
mixxxdj:masterfrom
Holzhaus:fix-cuecontrol-test
Apr 9, 2020
Merged

test/cuecontrol_test: Fix compile error due to missing method#2638
Be-ing merged 1 commit into
mixxxdj:masterfrom
Holzhaus:fix-cuecontrol-test

Conversation

@Holzhaus
Copy link
Copy Markdown
Member

@Holzhaus Holzhaus commented Apr 9, 2020

The test was added in #2593 but the Track::setSampleRate method was removed in
didn't help detecting this in this case.

The test was added in mixxxdj#2593 but the Track::setSampleRate method was removed in
didn't help detecting this in this case.
@Holzhaus Holzhaus added this to the 2.3.0 milestone Apr 9, 2020
@Holzhaus Holzhaus requested a review from uklotzde April 9, 2020 15:44
@daschuer
Copy link
Copy Markdown
Member

daschuer commented Apr 9, 2020

LGTM waiting for CI

@Holzhaus
Copy link
Copy Markdown
Member Author

Holzhaus commented Apr 9, 2020

The test was added in #2593 but the Track::setSampleRate method was removed in
didn't help detecting this in this case.

I someone was worried that I'm unable to write a coherent sentence: This comes from the commit message and apparently i mentioned PR #2601 at the beginning of a line which made it a comment.

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Apr 9, 2020

Master builds are failing everywhere right now, including when I build locally. I tested this locally and it fixed the build, so I'm going to go ahead and merge it before waiting for CI.

@Be-ing Be-ing merged commit 8037ae7 into mixxxdj:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants