-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
effect chain preset saving/loading, custom effect defaults, and parameter hiding/rearrangement #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
effect chain preset saving/loading, custom effect defaults, and parameter hiding/rearrangement #2618
Changes from all commits
Commits
Show all changes
552 commits
Select commit
Hold shift + click to select a range
42ea49e
LV2Backend: prevent copying container in for loop
Be-ing d834b37
effects: fix clazy warnings
Be-ing 4882396
add comment about EffectBackendType sort order
Be-ing 3d045f4
EffectManifest: use QLatin1String
Be-ing 0cd1fb8
EffectManifest::backendName: add comment noting it is for internal us…
Be-ing f214a3c
EffectsBackend::backendTypeToString use switch-case statement
Be-ing c40ff25
effects: fix more clazy warnings
Be-ing 518baf9
EffectSlot: avoid copies in loops
Be-ing aa67f47
effects: clang-format everything in src/effects
Be-ing 260ed55
effects: clang-format everything in src/engine/effects
Be-ing ca658f8
ControlEffectKnob: clang-format
Be-ing b6078a0
ControlPickerMenu: clang-format
Be-ing c4ede6c
effects: clang-format widgets
Be-ing 8121a34
effects: clang-format tests
Be-ing a08a1cc
DlgPrefEffects: clang-format
Be-ing a55a967
DlgPrefEQ: clang-format
Be-ing de38b7d
make pre-commit shut up
Be-ing 118ec6c
fix Qt 5.9 build
Be-ing 685425b
BuiltInBackend: clean up effect registration
Be-ing bea6016
EffectsBackendManager: update comment
Be-ing 862b7b6
LV2EffectProcessor: remove unnecessary #include
Be-ing 24047c1
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 9cf9d31
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 0b9dfa3
make pre-commit happy
Be-ing 2895b67
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 95b1ab4
DlgPreferences: remove unused parameter from merge conflict
Be-ing c7612e9
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing a4cae3f
EffectsBackendManager: change debug assertion to if statement
Be-ing e5e0ecc
EffectChainPresetManager: fix debug assertion without config
Be-ing 20f22e4
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing a16aa4c
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing c12036f
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing e8bfd6e
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 6c0676d
DlgPreferences: remove unused parameter
Be-ing 917ed3c
update legacy variable name to current convention
Be-ing 3a53a78
remove unneeded MOC includes for non-QObject classes
Be-ing cba4582
remove unused #include
Be-ing 9ea168b
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 277f57b
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 50a950a
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 6bbfa82
EffectChainPresetManager: forbid presets with empty names
Be-ing c95e8bb
EffectChainPresetManager: validate user-entered name
Be-ing 9870c1e
DlgPrefEffects: rearrange text, add hint about controllers
Be-ing 8d2196d
EffectChainPresetManager: prevent empty rename when importing
Be-ing 381f800
WEffectChainPresetButton: fix off by one error in label
Be-ing 60ea96c
EffectChainPresetManager: validate name of new chain presets
Be-ing 0080faf
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing b84698d
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing f72ae7d
fix code style issues after merge
Be-ing 017619c
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing fa11158
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 628f75e
make pre-commit happy
Be-ing 45cedc0
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 2f57c7c
EffectChainPresetManager: trim whitespace from preset names
Be-ing 9ca79b8
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing b52f427
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 579236d
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 6229788
LV2EffectProcessor: fix lilv header include
Be-ing ef8b0f4
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 0ad3286
DlgPreferences: clang-format fix
Be-ing c58da3d
WEffectPushButton: fix crash with invalid skins
Be-ing 4396b8c
EffectChainPresetManager: trim whitespace from imported presets
Be-ing efeab5b
WEffectChainPresetSelector: do not change preset on mouse scroll
Be-ing 386eba9
WEffectChainPresetSelector: set tooltips
Be-ing 6c375c6
WEffectChainPresetButton: do not accept focus
Be-ing 2bcfd54
WEffectChainPresetButton: remove superfluous connection to show menu
Be-ing 021ab5f
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 879dcca
Tango: fix fx slot v-layout with Super knobs
ronso0 bc21e16
Tango: push deck mixer to top with jump/loop controls shown
ronso0 ccc0171
Merge branch 'main' into effects_refactoring
ronso0 19a6ef7
WEffectChainPresetButton: note stylesheet support in TODO
Be-ing dc1bdca
EffectManifestParameter: remove commented debug message
Be-ing 9dd8b8c
BuiltInBackend: remove commented debug message
Be-ing 1f95765
EffectKnobParameterSlot: replace legacy NULL with nullptr
Be-ing 7011afb
EffectState: improve documentation
Be-ing 46cb0b9
EffectProcessor: clarify which methods are called from which thread
Be-ing 674655d
EffectsManager: add a note about initializing submanager classes
Be-ing e914b81
StandardEffectChain: add note about confusing EffectRack COs
Be-ing eeb1efb
EffectSlot: clang-tidy cleanup
Be-ing f8ac928
EffectChain: clang-tidy cleanup
Be-ing 550eca1
EngineEffect: improve documentation
Be-ing c7ac571
EngineEffectsManager: add/update documentation
Be-ing d7f10d1
GroupFeatureState: add documentation
Be-ing fdfb57f
SpecialEffectChains: add documentation
Be-ing cf29915
EngineEffectChain: replace NULL with nullptr
Be-ing 4c281f1
EngineEffectChain: remove unused method
Be-ing 7161502
EngineEffectChain: add documentation
Be-ing 5404a5f
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 48d15b4
SpecialEffectChains: fix grammatical error
Be-ing 7319d0e
PerGroupEffectChain: clarify documentation
Be-ing 56fe847
effects: fix inheritance issues
Be-ing 10cc327
EffectsBackend/EffectManifest: consolidate redundant string literals
Be-ing a3efdc9
EffectsBackend: fix typo in documentation
Be-ing afe8dbd
DlgPrefEq: do not repeat string literal
Be-ing 1be263b
EffectManifestParameter: remove unused SemanticHint enum
Be-ing 3af6071
EngineEffectsManager: clarify why allocating in audio thread is okay
Be-ing c5d522d
EffectState: elaborate in documentation
Be-ing 89b8247
WEffectChainPresetButton: remove redundant connections
Be-ing 89296b7
EffectProcessorImpl: update documentation
Be-ing d92120b
ParametricEqEffect: update URL for Discourse forum
Be-ing 37a3ef1
ParametricEQEffect: add notes about allocation not in audio thread
Be-ing 6056189
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing e744a53
EffectState/EffectProcessor: improve documentation
Be-ing c9c0718
EffectChainPreset: update documentation
Be-ing 8f73c7d
EffectsMessenger: add link explaining design choice
Be-ing 206db13
EngineEffectsManager: improve documentation
Be-ing 58d58c3
EngineEffect: clarify documentation
Be-ing eeac82b
EngineEffectsManager: add documentation for methods
Be-ing fb905f8
EngineEffectsManager: add signal flow diagram
Be-ing da65f77
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 645a83e
DlgPrefEQ: remove static keyword from functions in anonymous namespace
Be-ing 60f7bdd
DlgPrefEQ: remove unneeded else branch
Be-ing 3f1beb1
EffectsManager: remove unused string constants
Be-ing 3d5931e
EffectsMessenger: rename startShutdownProcess to initiateShutdown
Be-ing 72d05af
EchoEffect: restore accidentally deleted setMetaKnobDefault call
Be-ing 7e17294
ParametricEQEffect: use SampleRate class instead of unsigned int
Be-ing 8c6636d
EffectManifest: rename alphabetize to sortLexigraphically
Be-ing fd57f63
EngineEffect: remove unused m_pEffectsManager member
Be-ing ae9693d
use kNoEffectString constant more
Be-ing a62cbc8
EffectChainPresetManager: remove unused member
Be-ing 236af41
EffectsMessenger: document that it runs in the main thread
Be-ing 3c7403e
DlgPrefEffects: use parented_ptr
Be-ing cb58adf
EffectChainPresetManager: separate error text with a newline
Be-ing 006216a
EffectChain: add debug assertions regarding EngineEffectChain
Be-ing 81df0bf
Tango: add basic styles for menu of WEffectChainPresetButton
ronso0 7f94758
EffectParameterSlot: remove unused m_pEffectSlot
Be-ing 0ea0d74
EffectChain: static_cast enum class directly to double
Be-ing 7cbaaf6
EffectChain: consolidate load_preset and loaded_preset into one RW CO
Be-ing 661ac8f
EffectChain: fix loaded_preset off-by-one error
Be-ing da2e71b
EffectChain: update loaded_preset when chain list is updated
Be-ing 4a12d74
EffectChain: rename nameChanged signal to presetNameChanged
Be-ing 1c7c9b7
EffectSlot: rename load_effect to loaded_effect and make it read/write
Be-ing ad70288
EffectChain: remove setPresetName method
Be-ing fef8a44
VisibleEffectsList: use debug assertions
Be-ing 4263380
Revert "EchoEffect: restore accidentally deleted setMetaKnobDefault c…
Be-ing 7d72822
EffectManifest: optimize sortLexigraphically function
Be-ing 341f6e9
EffectChain: fix setting of mix and mix_mode defaults
Be-ing 7b0a0d5
split EffectChain subclasses into separate files
Be-ing e53faa3
rearrange #includes
Be-ing ae4aba7
EffectChainPresetManager: add comment explaining sorting order
Be-ing aa9a449
DlgPrefEQ: disable EQ acting on waveform when loading non-EQ effect
Be-ing 16e113c
EffectsManager: rename isAdoptMetaknobValueEnabled
Be-ing ce2b4a6
DlgPrefEQ: fix loading of settings
Be-ing ea70102
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 077372d
EffectsBackendManager: fix handling of upgrade from Mixxx 2.3
Be-ing 0a7987c
EffectChainPresetManager: fix renaming presets
Be-ing e303837
log warnings when failing to read effect chain preset XML file
Be-ing d4a1bca
EffectChainPresetManager: fix deletion of presets with sanitized names
Be-ing d0af5f4
Tango: fixup effect chain menu
ronso0 9602609
Tango: style QuickEffect selector
ronso0 bcd3383
Tango: style WEffectChainPresetButton
ronso0 e7b8061
DlgPrefEffects: reimport default presets with Defaults button
Be-ing 328e3a3
EffectChainPresetManager: use "Export" in title of export dialog
Be-ing 642ebd1
WEffectChainPresetButton: "Save preset" -> "Save new preset"
Be-ing c525026
use QChar and QStringLiteral in effects item models
Be-ing 7124c1a
EffectsBackend: use constexpr char[] for translated strings
Be-ing d601fcb
turn EffectChainMixMode into a class with a Type enum
Be-ing 2151a8f
EffectChain: fix slotControlLoadedChainPresetRequest for QuickEffectC…
Be-ing f70d342
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 5060718
EffectChainPresetManager: handle old effects.xml with presets existing
Be-ing 13a438e
EffectChainPresetManager: improve error handling in importDefaultPresets
Be-ing a0dc621
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing dd7ba9b
EffectChainPresetManager: fix emission of lists updated signals
Be-ing d71cb69
WEffectChainPresetButton: hardcode 3 effect slots for now
Be-ing e90b493
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 0c7d453
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 75c7246
LateNight: fix broken style
Be-ing c637cae
Merge remote-tracking branch 'mixxx/main' into effrefact3
ronso0 1492915
fxrefact-resolve-conflicts
ronso0 d0eda1b
EffectChainPresetManager: validate renamed preset names
Be-ing ee651f5
Merge branch 'main' of github.com:mixxxdj/mixxx into effects_refactoring
Holzhaus dcbd9cd
EffectChainPresetManager: Unsplit some strings to help translators
Holzhaus b55c56a
EffectChainPresetManager: Use toByteArray to write XML document
Holzhaus 17f42fc
EffectChainPresetManager: Add various string fixes
Holzhaus 7331d21
EffectChainPresetManager: Rename effectSupported to effectAvailable
Holzhaus 6883735
EffectChainPresetManager: Fix trailing whitespace
Holzhaus 790364e
Merge branch 'main' of github.com:mixxxdj/mixxx into effects_refactoring
Holzhaus cce1568
EffectChainPresetManager: Remove redudant file.close()
Holzhaus 11e4b12
EffectChainPresetManager: Return if preset deletion fails
Holzhaus cbc2acd
EffectChainPresetManager: Replace toString().toUtf8() with toByteArray()
Holzhaus 97ada3f
EffectChainPresetManager: Continue on invalid preset name during import
Holzhaus 9980147
EffectChainPresetManager: Rename "SavedPresets" to "UserPresets"
Holzhaus 6161a39
EffectChainPresetManager: Show QFile.errorString() where applicable
Holzhaus 3a32979
EffectManifestParameter: Make setParameterType() private
Holzhaus 280b936
DlgPrefEffects: Fix unitialized member in constructor
Holzhaus f1d1326
EffectPreset: Ensure that all members are initialized in constructor
Holzhaus 4de0539
EffectChainMixMode: Add kNumModes constant
Holzhaus 3965be9
EffectChainPreset: Fix uninitialized members in constructor
Holzhaus b949bc0
EffectSlot: Simplify code using helper variable
Holzhaus ebfc297
EffectChainPresetManager: Use homePath instead of cwd for file dialog
Holzhaus 897fab1
EffectManifestParameter: Fix enum class base type and member naming
Holzhaus aee13df
EffectXml: Add missing k prefix
Holzhaus e83bd83
VisibleEffectsList: Use QT_FORWARD_DECLARE_CLASS macro
Holzhaus 3f145d2
EffectsBackendManager: Use kNoEffectString instead of "None"
Holzhaus 3d88d79
EffectsBackendManager: Add warning if manifest was not found
Holzhaus 99f3967
WEffectParameterNameBase: Use kNoEffectString instead of "None"
Holzhaus 4d3d089
EffectChainPresetManager: Add missing error handling
Holzhaus d22df2c
QuickEffectChain: add comment for unintuitive code
Be-ing cc9f918
EffectChainPresetListModel: validate dropped text
Be-ing 6cde58a
Tango/LateNight: fix merge conflicts
Be-ing 381c411
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 686314c
EffectChainPresetManager: automatically rename duplicate presets
Be-ing 207a904
EffectChainPresetManager: immediately copy imported preset files
Be-ing 49f1a26
EffectChain: factor out `+ 1` to separate function
Be-ing e1132b6
QML: Fix broken effects integration
Holzhaus 6d6ea72
EffectChainPresetManager: use while loop for duplicate presets
Be-ing c7fc756
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing ab4d3dd
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing aeadc65
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing bf25de6
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 2b9140a
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 8baa8c3
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 1c7f7e7
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 8bc19b2
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 01a61a9
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing f5864c0
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 67f35d0
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 4d7bde1
built-in effects: use constexpr instead of const
Be-ing f58f68e
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing f8f6260
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing c462211
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing de8b3a4
EffectChainPresetListModel: fix validation of dropped text
Be-ing ebec5ef
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 681e375
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 0cb59e8
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 60087aa
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 3cd6a93
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing d967eec
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing e4e8cc8
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing ef6e73d
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 02e7b6a
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 5d3d57d
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing c4ad6b1
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 196bb7d
Rename loaded_effect related variables to match the CO name
daschuer c3a15e0
Remove redundant check in loadEffectWithDefaults()
daschuer e145a38
Remove redundant copy of default constructed EffectParameterPreset
daschuer 199637b
Exit effect parameter presets loop once we have a match to save some …
daschuer 06b3f2b
Added missing 0 set of loaded_effect when it has been unloaded
daschuer 4141b2d
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 8b9d712
Ignore 0 in EffectChain::slotControlChainSelector to match the behavi…
daschuer d385385
Simplify control flow in loadChainPreset
daschuer 445e9b8
Remove redundant setting of m_pControlLoadedChainPreset
daschuer faaa80f
Remove pointless check if group is empty.
daschuer 1a5d702
EffectChain: do not reload preset when chain_selector set to 0
Be-ing 83790ed
EffectChain: fix inconsistent ControlObject names & add aliases
Be-ing 900bf6b
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 864c682
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 4793f7b
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing 8a70023
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing c9d4bb0
Merge remote-tracking branch 'upstream/main' into effects_refactoring
Be-ing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| <?xml version='1.0' encoding='utf-8'?> | ||
| <EffectChain> | ||
| <Name>Echoverb HP</Name> | ||
| <MixMode>DRY+WET</MixMode> | ||
| <SuperParameterValue>0</SuperParameterValue> | ||
| <Effects> | ||
| <Effect> | ||
| <MetaParameterValue>0</MetaParameterValue> | ||
| <Id>org.mixxx.effects.threebandbiquadeq</Id> | ||
| <BackendType>Built-In</BackendType> | ||
| <Parameters> | ||
| <Parameter> | ||
| <Id>low</Id> | ||
| <Value>0.34375</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
|
Holzhaus marked this conversation as resolved.
|
||
| </Parameter> | ||
| <Parameter> | ||
| <Id>mid</Id> | ||
| <Value>1</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>high</Id> | ||
| <Value>1</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>killLow</Id> | ||
| <Value>0</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>killMid</Id> | ||
| <Value>0</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>killHigh</Id> | ||
| <Value>0</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| </Parameters> | ||
| </Effect> | ||
| <Effect> | ||
| <MetaParameterValue>0</MetaParameterValue> | ||
| <Id>org.mixxx.effects.echo</Id> | ||
| <BackendType>Built-In</BackendType> | ||
| <Parameters> | ||
| <Parameter> | ||
| <Id>delay_time</Id> | ||
| <Value>0.5</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>feedback_amount</Id> | ||
| <Value>0.707946</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>pingpong_amount</Id> | ||
| <Value>0</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>send_amount</Id> | ||
| <Value>0</Value> | ||
| <LinkType>LINKED</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>quantize</Id> | ||
| <Value>1</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>triplet</Id> | ||
| <Value>0</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| </Parameters> | ||
| </Effect> | ||
| <Effect> | ||
| <MetaParameterValue>0</MetaParameterValue> | ||
| <Id>org.mixxx.effects.reverb</Id> | ||
| <BackendType>Built-In</BackendType> | ||
| <Parameters> | ||
| <Parameter> | ||
| <Id>decay</Id> | ||
| <Value>0.5</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>bandwidth</Id> | ||
| <Value>1</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>damping</Id> | ||
| <Value>0.277905</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| <Parameter> | ||
| <Id>send_amount</Id> | ||
| <Value>1</Value> | ||
| <LinkType>NONE</LinkType> | ||
| <LinkInversion>0</LinkInversion> | ||
| <Hidden>0</Hidden> | ||
| </Parameter> | ||
| </Parameters> | ||
| </Effect> | ||
| <Effect/> | ||
| </Effects> | ||
| </EffectChain> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.