Skip to content

Fix runtime dependencies of LibraryScanner#2515

Merged
daschuer merged 6 commits into
mixxxdj:masterfrom
uklotzde:libraryscanner
Feb 24, 2020
Merged

Fix runtime dependencies of LibraryScanner#2515
daschuer merged 6 commits into
mixxxdj:masterfrom
uklotzde:libraryscanner

Conversation

@uklotzde
Copy link
Copy Markdown
Contributor

@uklotzde uklotzde commented Feb 24, 2020

Extracted from #2511 (without URI changes) that should fix the test failures in #2508.

  • Disable LibraryScanner during library tests
  • Remove dependencies on TrackCollection from LibraryScanner
  • Use Qt::DirectConnection for signal-to-signal connections

TODO (see code): The LibraryScanner should be extracted and decoupled from TrackCollectionManager in the long term.

@uklotzde
Copy link
Copy Markdown
Contributor Author

AppVeyor CI failure is unrelated: EngineSyncTest.RateChangeTest (Failed)

@uklotzde uklotzde added this to the 2.3.0 milestone Feb 24, 2020
@daschuer
Copy link
Copy Markdown
Member

This has also an empty library here.
It turns out that the issue already exists in Master.
I am investigating.

@uklotzde
Copy link
Copy Markdown
Contributor Author

uklotzde commented Feb 24, 2020

We didn't receive any reports about database issues in master. So my first guess would be that this might be caused by local circumstances. Nevertheless we should try to find the cause. Unfortunately no one else without experiencing those issues can help here.

@daschuer
Copy link
Copy Markdown
Member

Got it. It was caused by #2470
My database schema was already at 31. I have manually set the version number down to 30 and now my tracks are back.

@daschuer
Copy link
Copy Markdown
Member

This one works and looks good. Thank you.

@daschuer daschuer merged commit 0fffbac into mixxxdj:master Feb 24, 2020
@uklotzde
Copy link
Copy Markdown
Contributor Author

@daschuer That's the manual intervention I mentioned in #2514 that will still needed. We cannot detect this reliably. Developers need to be aware of this when testing PRs that contain a database migration with a preliminary version number. The final version number may differ if other PRs with schema changes get merged earlier.

@uklotzde uklotzde deleted the libraryscanner branch February 24, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants