Fix runtime dependencies of LibraryScanner#2515
Conversation
Deriving from QThread is discouraged when running an event loop.
|
AppVeyor CI failure is unrelated: EngineSyncTest.RateChangeTest (Failed) |
|
This has also an empty library here. |
|
We didn't receive any reports about database issues in master. So my first guess would be that this might be caused by local circumstances. Nevertheless we should try to find the cause. Unfortunately no one else without experiencing those issues can help here. |
|
Got it. It was caused by #2470 |
|
This one works and looks good. Thank you. |
|
@daschuer That's the manual intervention I mentioned in #2514 that will still needed. We cannot detect this reliably. Developers need to be aware of this when testing PRs that contain a database migration with a preliminary version number. The final version number may differ if other PRs with schema changes get merged earlier. |
Extracted from #2511 (without URI changes) that should fix the test failures in #2508.
TODO (see code): The
LibraryScannershould be extracted and decoupled fromTrackCollectionManagerin the long term.