Add missing override and remove unused variables

src/controllers/controllerinputmappingtablemodel.cpp

@@ -183,7 +183,6 @@ QVariant ControllerInputMappingTableModel::data(const QModelIndex& index,
         }
 
         const MidiInputMapping& mapping = m_midiInputMappings.at(row);
-        QString value;
         switch (column) {
             case MIDI_COLUMN_CHANNEL:
                 return MidiUtils::channelFromStatus(mapping.key.status);

src/controllers/controlleroutputmappingtablemodel.cpp

@@ -151,7 +151,6 @@ QVariant ControllerOutputMappingTableModel::data(const QModelIndex& index,
         }
 
         const MidiOutputMapping& mapping = m_midiOutputMappings.at(row);
-        QString value;
         switch (column) {
             case MIDI_COLUMN_CHANNEL:
                 return MidiUtils::channelFromStatus(mapping.output.status);

src/controllers/controllerpresetfilehandler.cpp

@@ -32,12 +32,6 @@ ControllerPresetPointer ControllerPresetFileHandler::loadPreset(const QString& p
         return ControllerPresetPointer();
     }
 
-    // TODO(XXX): This means filenames can't have .foo.midi.xml filenames. We
-    // should regex match against the end.
-    // NOTE(rryan): We prepend a dot because all the XXX_PRESET_EXTENSION
-    // defines include the dot.
-    QString extension = "." + scriptPathInfo.completeSuffix();
-
     ControllerPresetFileHandler* pHandler = NULL;
     if (scriptPath.endsWith(MIDI_PRESET_EXTENSION, Qt::CaseInsensitive)) {
         pHandler = new MidiControllerPresetFileHandler();

src/effects/lv2/lv2manifest.cpp

@@ -42,12 +42,10 @@ LV2Manifest::LV2Manifest(const LilvPlugin* plug,
                 audioPortIndices.append(i);
                 inputPorts++;
                 info = lilv_port_get_name(m_pLV2plugin, port);
-                QString paramName = lilv_node_as_string(info);
             } else if (lilv_port_is_a(m_pLV2plugin, port, properties["output_port"])) {
                 audioPortIndices.append(i);
                 outputPorts++;
                 info = lilv_port_get_name(m_pLV2plugin, port);
-                QString paramName = lilv_node_as_string(info);
             }
         }
 

src/encoder/encoderrecordingsettings.h

@@ -28,7 +28,7 @@ class EncoderRecordingSettings : public EncoderSettings {
     }
 
     // Sets the compression level
-    virtual void setCompression(int compression) {
+    void setCompression(int compression) override {
         Q_UNUSED(compression);
         DEBUG_ASSERT(!"unimplemented");
     }

src/library/browse/browsetablemodel.cpp

@@ -298,7 +298,6 @@ Qt::ItemFlags BrowseTableModel::flags(const QModelIndex &index) const {
     // waveform widget to load a track into a Player).
     defaultFlags |= Qt::ItemIsDragEnabled;
 
-    QString track_location = getTrackLocation(index);
     int column = index.column();
 
     switch (column) {

src/library/crate/cratefeature.cpp

@@ -722,7 +722,6 @@ void CrateFeature::slotExportPlaylist() {
             ConfigKey("[Library]", "UseRelativePathOnExport"));
 
     // Create list of files of the crate
-    QList<QString> playlist_items;
     // Create a new table model since the main one might have an active search.
     QScopedPointer<CrateTableModel> pCrateTableModel(
         new CrateTableModel(this, m_pLibrary->trackCollections()));

src/musicbrainz/musicbrainzclient.cpp

@@ -136,7 +136,6 @@ void MusicBrainzClient::replyFinished() {
         QString message = jsonObject["error"].toString();
         QStringList propertyNames;
         QStringList propertyKeys;
-        QString strReply = (QString)reply->readAll();
         emit networkError(
              reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt(),
              "MusicBrainz", message, kDefaultErrorCode);

src/preferences/dialog/dlgprefdeck.cpp

@@ -115,7 +115,6 @@ DlgPrefDeck::DlgPrefDeck(QWidget * parent, MixxxMainWindow * mixxx,
             this,
             &DlgPrefDeck::slotTimeFormatChanged);
 
-    QLocale locale;
     // Track Display model
     comboBoxTimeFormat->clear();
 

src/test/coverartutils_test.cpp

@@ -50,7 +50,6 @@ class CoverArtUtilTest : public LibraryTest, public CoverArtCache {
 };
 
 TEST_F(CoverArtUtilTest, extractEmbeddedCover) {
-    QImage cover;
     QImage referencePNGImage = QImage(kReferencePNGLocationTest);
     QImage referenceJPGImage = QImage(kReferenceJPGLocationTest);
 

src/util/db/dbnamedentity.h

@@ -30,7 +30,6 @@ class DbNamedEntity: public DbEntity<T> {
         DEBUG_ASSERT(!hasName());
     }
     bool parseName(const QString& name) {
-        QString normalizedName(normalizeName(name));
         if (name.isEmpty()) {
             return false;
         } else {