Soundless joyMIDI: Mapping for joyMIDI

[bcc6]

Hi, this mapping support portable MIDI controller joyMIDI. Thanks
Mixxx wiki (joyMIDI page)

[Holzhaus]

Hi, is this mapping using new features that are not present in the 2.2 release? If not, can you rebase on 2.2?

[bcc6]

OK, already merge v2.2

[uklotzde]

Merging 2.2 is the wrong direction. Please rebase your commits onto 2.2 instead.

[bcc6]

Sorry, can tell me how to do.

[Holzhaus]

Just run this command:

$ git rebase -i 2.2

This will then open a text editor. Delete all lines except the one that says:

pick <commitid> Soundless joyMIDI: Mapping for joyMIDI

Then save and close the file.

[uklotzde]

Or use git rebase -onto. The result must only contain your own commits, not anything else.

[bcc6]

Finally, done.

[uklotzde]

But now the CI builds seem to be out of sync, even though the corresponding configuration files have not been modified in any of the commits. Not sure if we need to close this PR and open a new one?

[bcc6]

Any suggestion ?

[Holzhaus]

I don't think a new PR is necessary. The only relevant "CI" for controller mappings is the CodeFactor linter, and I can just run eslint locally instead.

I'll review this mapping tomorrow.

[Holzhaus]

Thanks for contributing a mapping for this unusual little controller! I had a look at the Wiki page and the mapping looks well thought out and should make good use of the buttons available.

As I don't have the controller myself, I can't test it, but I trust that you tested the mapping thorougly. I found few minor issues, but apart from that the mapping looks good to me.

@Be-ing Do you also want to take a look?

[Holzhaus]

Thanks! We're almost there. There are still some eslint issues that are fixed by bcc6#1. Please merge the PR and fix the description in the XML, then we can merge IMO.

[Holzhaus]

@bcc6 Thanks!