Add CMake to Travis CI config#2392
Conversation
|
Is Mixxx build twice than? |
|
Yes, but as a separate job, so it shouldn't make the timeouts worse. The complete cmake build job on Linux takes less than 5 minutes due to ccache. On OSX the problem is homebrew taking ages to install dependencies, not the build itself. |
|
Ah Ok, that makes sense. |
|
The macOS CMake build timed out, whereas the SCons build finished in time. Merge? |
I'm currently checking if hardcoding 4 threads makes the build pass reliably. This is what we did before, and I switched that to |
|
Looks like that worked, let's wait for another CI build. If everything works we can merge this. |
| # For SCons builds | ||
| - SCONSFLAGS="test=1 mad=1 faad=1 opus=1 modplug=1 wv=1 hss1394=0 virtualize=0 debug_assertions_fatal=1 verbose=0" | ||
| # For CMake builds | ||
| - CMAKEFLAGS="-DMAD=ON -DFAAD=ON -DOPUS=ON -DMODPLUG=ON -DWAVPACK=ON -DHSS1394=OFF" |
There was a problem hiding this comment.
FAAD2 should be disabled for macOS builds, both for SCons and CMake. I see errors to load the corresponding dynamic library at runtime during the tests. We could move the corresponding options into the platform-dependent EXTRA flags.
There was a problem hiding this comment.
But we install faad2 via homebrew, strange.
|
The concurrent GlobalCacheTrack test on macOS timed out after 30 sec, but only in the CMake build. The same test in the SCons build finished after 25 sec. On my local Skylake system this test runs for 0.5 sec. |
|
Oof, the Mac builds on Travis seem to be at risk of failing due to homrbrew, locking up or timing out. I'm considering to undo the OSX change and only add a Linux CMake build atm. @uklotzde what do you think? |
|
Fix for the test timeouts: uklotzde@7a20bc9 Locally this test actually took ~2 sec. vs. 25-30 sec. on Travis. |
|
The macOS environment setup is really brittle and a mess. Even though it fails often I would like to keep it in to detect new issues early. |
|
The test finished in 24.56 sec. Hopefully enough headroom to not exceed the 30 sec. timeout limit. |
|
LGTM |
|
@Holzhaus SCons builds on macOS is failing for all new PRs with the same error. Are the mismatching OS library versions for gtest (10.11 vs. 10.13) just coincidence or related to the recent changes in any way? I don't see a connection. |
|
I'm currently investigating this. |
3 participants
Unlike PR #2332, this does not replace SCons with CMake. Instead it adds CMake builds to the CI config but still keeps the SCons config as well.
This allows us to prevent breakage in either of those two build systems.