Skip to content

scripts/qsscheck: Also check default stylesheets#2391

Merged
Holzhaus merged 1 commit intomixxxdj:masterfrom
Holzhaus:qsscheck
Dec 13, 2019
Merged

scripts/qsscheck: Also check default stylesheets#2391
Holzhaus merged 1 commit intomixxxdj:masterfrom
Holzhaus:qsscheck

Conversation

@Holzhaus
Copy link
Copy Markdown
Member

@Holzhaus Holzhaus commented Dec 9, 2019

Add support for qss stylesheets added in PR #2362.

@Holzhaus Holzhaus added the build label Dec 9, 2019
@uklotzde
Copy link
Copy Markdown
Contributor

@ronso0 Any comments on this?

@uklotzde uklotzde added this to the 2.3.0 milestone Dec 10, 2019
@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Dec 10, 2019

nope. Can't evaluate the script, and I suppose @Holzhaus tested it sufficiently.

@Holzhaus
Copy link
Copy Markdown
Member Author

@uklotzde We already found some issues using that script, e.g. #2387, #2374 and the qss syntax errors fixed by #2342. For the current master branch, there are no false positives. The script is certainly not perfect, but it can help keeping the qss scripts clean.

If the script complains and we determine that it's a false positive, we can still ignore the warning and merge anyway, and also fix the script itself.

@Holzhaus Holzhaus merged commit 0d21849 into mixxxdj:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants