Pioneer DDJ-400#2385
Pioneer DDJ-400#2385nschloe wants to merge 320 commits intomixxxdj:masterfrom nschloe:pioneer-ddj400
Conversation
… / hotcue, use 'cue_default' for mini decks' Play right-click
AppVeyor build on Windows with VS 2017 failed.
|
This PR contains a lot of unrelated commits now. It looks like you rebased onto master instead of 2.2. Do an interactive rebase |
I did indeed. I don't know how to undo either. |
|
Have you set up the mixxxdj repository as a remote? The wiki has instructions to set it up as a remote called "upstream", so the command would be |
|
Yeah I always do that, but then I've never done an "interactive" rebase. I don't know what do to with the interface git gives me there. It just presents me with a million commits which I have to manually pick? |
|
Delete the lines for every commit that doesn't have to do with your mapping, leaving only the commits for your mapping. |
There are hundreds of commits, and I only see the title, not the author. It's too much work. I'll simply start a new PR. |
|
See #2403. |
|
All of your commits are at the end. It should be easy to delete the commits before that. |
|
I've played around with it for half an hour now but I can't seem to get the rebase to work. I did but I still have all those commits here. Gah. Edit: It did work over at #2403 so let's just take it from there. |
After #2143 and #2312, this is another take on the Pioneer DDJ-400.
This PR implements most of the basic functionality of the controller:
I've successfully used this on two occasions and only found minor glitches. For example, when a hot cue point is set it lights up (this is good), but when shift is pressed, the lights go out. The functionality is still there though.
There are still a bunch of advanced controls missing, for example the entire effects section. This can be added in second PR though.
The visual XML composer was of great help creating this PR as was @WarkerAnhaltRanger first pass.
I'd suggest we keep it simple here and try to add more functionality in follow-up PRs. I'd be happy about some feedback of course.