Add qsscheck to CI pipeline and improve .travis.yml config#2375
Add qsscheck to CI pipeline and improve .travis.yml config#2375Holzhaus merged 20 commits intomixxxdj:masterfrom
Conversation
|
Please check for trailing whitespaces that CodeFactor complains about. |
Ok, done. |
|
checking by travis is good, but is there a way we can integrate it into mixxx-test? even just having a simple C++ test file that shells out to python could work. |
ywwg
left a comment
ywwg
left a comment
There was a problem hiding this comment.
Just some python style nits. Thanks for this useful utility!
| for root, dirs, fnames in os.walk(os.path.join(mixxx_path, 'src')): | ||
| for fname in fnames: | ||
| ext = os.path.splitext(fname)[1] | ||
| if ext in ('.h', '.cpp'): |
There was a problem hiding this comment.
(see below comment -- here's another place where we can save a level of indentation)
There was a problem hiding this comment.
How? We have an elseif case, too.
What's the benefit? For PRs that only make skin changes, you'd have to wait until Mixxx is built (2 minutes vs >30min). Also, this would also introduce a dependency on Python/PyQt/tidycss, which means that we need to install them on OSX and Appveyor, too. That would increase the likelyness of running into a timeout. |
If people want to run the script they will need these things anyway, right? But I think it's ok to submit without having test integration. But we should make sure to update the skinning documentation to call out this script so people know about it. |
|
Let's wait for the CI builds. If we have a clean state and nobody raises any concerns, I'll merge this tomorrow, so that this can prevent introducing new issues in the other pending skin PRs. |
3 participants
This adds a simple checker script for
*.qssfiles to thescripts/folder and runs it on Travis CI builds. It also cleans up the.travis.ymlfile a bit.