Skip to content

Skins: minimize Fx link invert button, put it next to link button#2339

Merged
Be-ing merged 2 commits intomixxxdj:masterfrom
ronso0:fx-link-buttons
Nov 12, 2019
Merged

Skins: minimize Fx link invert button, put it next to link button#2339
Be-ing merged 2 commits intomixxxdj:masterfrom
ronso0:fx-link-buttons

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Oct 31, 2019

This is a pretty simple tweak that moves the rarely used Fx link inversion button next to the link mode button. With about one more library line, LateNight benefits the most from the additional v-space.

image

Addon:
desaturated Fx paramter controls in LateNight

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Nov 4, 2019

I'll revert the last commit (desaturated Fx controls in LateNight) and put it in #2342 , so this will be about link invert buttons only.

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Nov 5, 2019

Good idea. Some thoughts:
The red, compared to the green looks alarming in late night. On the other hand "something" different is required to destinuish two buttons. Did you considder other options? How about making the invert button quadratic with more distance or even round?

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Nov 5, 2019

Try LateNight with playing decks, Sync locked and a beatloop: all status indicators are alarmig red.
so the Super link invert btn blends in :)
I tried circular invert button, yes, but IMO they were too small.

I'll increase the spacing and test with white bg color, though.

@ronso0 ronso0 mentioned this pull request Nov 8, 2019
2 tasks
@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Nov 12, 2019

Nice idea. It has long bothered me how much vertical space those took up but I didn't think of any good alternatives.

@Be-ing Be-ing merged commit 810aac2 into mixxxdj:master Nov 12, 2019
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Nov 12, 2019

@daschuer I noticed my post with screen snippets of the alternative colors somehow fell off the table.. I tried yellow but that was too close to green. White didn't work IMO because it wasn't strong enough considering the meaning of 'Link invert'.

@ronso0 ronso0 deleted the fx-link-buttons branch November 12, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants