reduce number of sent midi messages for wheel leds#2326
reduce number of sent midi messages for wheel leds#2326Be-ing merged 1 commit intomixxxdj:2.2from goddisignz:ddj-sx-reduce-messages
Conversation
|
Again, please rebase this on the 2.2 branch. |
|
Oh sorry, I didn't get your comment the first time. I was just confused where all these commits come from and thought I just made a mistake in the PR. Will do. |
|
@goddisignz In case you're not fluent in # First add the "upstream" remote and make sure you have the latest state of it
$ git remote add upstream https://github.com/mixxxdj/mixxx.git
$ git fetch upstream
# Then rebase on the "2.2" branch
$ git rebase -i upstream/2.2The last command will open an editor window which shows all commits since 2.2. Delete all lines that do not belong to your PR. Basically, keep only the line that says $ git push -f origin ddj-sx-reduce-messages |
|
Thanks @Holzhaus. I did rebasing before but never to a different branch. |
|
Thank you! |
I had the problem that the rate that midi messages are sent to the controller apparently exceeds the maximum when the audio buffer size is set lower than 10ms. It was caused by the "playposition" control that in the ddj-sx controller script updates the position of the wheel leds inside the jog wheel. Apparently, when the buffer size is reduced, the number of position updates increases.
What happens than can be seen in the following video. All controls react in a delayed behavior as soon as two decks are playing and updating the wheel leds.
https://projects.goddi.ddnss.eu/wp-content/uploads/delayed_behavior.mkv
Therefore, I adapted the DDJ-SX script such that a midi message is only sent when the position of the wheel leds is really changed. Thanks to @JosepMaJAZ who pointed me towards the cause of the problem and the solution.