Hide the battery widget when the status is unknown#2319
Merged
daschuer merged 1 commit intomixxxdj:masterfrom Oct 17, 2019
Merged
Hide the battery widget when the status is unknown#2319daschuer merged 1 commit intomixxxdj:masterfrom
daschuer merged 1 commit intomixxxdj:masterfrom
Conversation
Member
|
LGTM, thank you. |
Member
|
Will this change makes sense, I'm frequently confused why my battery icon disappears for like half a minute after plugging in the charger. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was briefly discussed here: #2283 (comment)
The widget is hidden by default and only becomes visible once the status is known.
This means that the
unknown-icons are never presented to the user.(The status can be
unknownif there is no battery present or if there are problems reading the status. I think in case of problems we should print/log errors instead of showing icons)