Follow-up: Use PainterScope everywhere#2302
Merged
daschuer merged 3 commits intomixxxdj:masterfrom Sep 28, 2019
uklotzde:painterscope
Merged
Follow-up: Use PainterScope everywhere#2302daschuer merged 3 commits intomixxxdj:masterfrom uklotzde:painterscope
daschuer merged 3 commits intomixxxdj:masterfrom
uklotzde:painterscope
Conversation
Contributor
uklotzde
commented
Sep 28, 2019
uklotzde
commented
- Use PainterScope everywhere instead of manually invoking QPainter::save() and QPainter::restore()
- Minor readability improvements in the recently changed table item delegates
Member
|
LGTM, Thank you very much for keeping the whole code consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.