Mapping for Hercules DJControl Inpulse 200#2104
Mapping for Hercules DJControl Inpulse 200#2104DJPhatso wants to merge 2 commits intomixxxdj:masterfrom
Conversation
Initial release of MIDI configuration files for Hercules DJControl Inpulse 200
uklotzde
changed the title
|
Ready for merge? Code is readable, Wiki page exists. |
| DJCi200.shutdown = function() { | ||
|
|
||
| midi.sendShortMsg(0xB0, 0x7F, 0x00); | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Please add a newline at end of file. Most editors do this automatically, which would pollute patch diffs later on. So better add it now ;-)
| </outputs> | ||
|
|
||
| </controller> | ||
| </MixxxMIDIPreset> No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file.
|
@Holzhaus thanks for jumping in here. @DJPhatso I apologize for putting off reviewing your pull requests (as well as some other controller mappings) for so long. I have some time now and will go through them. Feel free to leave a comment to remind us that you're waiting on a review if it's been a long time with no activity. |
|
Hi guys, You might want to hold off reviewing for the moment. Following all the changes and code cleanup made by @kerrickstaley for the DJControl Starlight mapping (which has been approved), I've just started applying the same changes to the Inpulse 200 & 300 mappings. |
|
Mapping files for Hercules DJControl Inpulse 200 Changes to v1.2 Code cleanup. Fix seek-to-start and cue-master behavior. v1.0 : Original forum release |
|
Hi, can you rebase on 2.2? This could also be part of the 2.2.4 release. |
| //////////////////////////////////////////////////////////////////////// | ||
| // JSHint configuration // | ||
| //////////////////////////////////////////////////////////////////////// | ||
| /* global engine */ | ||
| /* global script */ | ||
| /* global print */ | ||
| /* global midi */ | ||
| //////////////////////////////////////////////////////////////////////// |
There was a problem hiding this comment.
Please remove the JSHint config, this conflicts with eslint that we're using now.
| DJCi200.kScratchActionSeek = 2; | ||
| DJCi200.kScratchActionBend = 3; | ||
|
|
||
| //function DJCi200() {} |
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
I think a single newline suffices here (and also in other parts of the mapping).
|
I thought I had closed this one already. |
4 participants
Initial release of MIDI configuration files for Hercules DJControl Inpulse 200