Skip to content

Velocity sensitive ComponentsJS SamplerButtons#2032

Merged
Be-ing merged 2 commits intomixxxdj:masterfrom
Swiftb0y:components_samplerbutton_velocity
Feb 23, 2019
Merged

Velocity sensitive ComponentsJS SamplerButtons#2032
Be-ing merged 2 commits intomixxxdj:masterfrom
Swiftb0y:components_samplerbutton_velocity

Conversation

@Swiftb0y
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y commented Feb 16, 2019 •
edited
Loading

You can now add velocity: true, while creating a SamplerButton. This will set the channel volume of the sampler accordingly when launched.

TODO:

  • Testing
  • Documenting

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Feb 22, 2019

this looks like an interesting feature.
I think velocity: true is not self explaining.
how about
volumeByVelocity: true
or similar.

@Swiftb0y
Copy link
Copy Markdown
Member Author

Swiftb0y commented Feb 22, 2019

how about velocitySensitive?

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Feb 22, 2019

It is missing that the "volume" is effected

@daschuer
Copy link
Copy Markdown
Member

daschuer commented Feb 23, 2019

LGTM @Be-ing anything else to consider before merge?

@Be-ing
Copy link
Copy Markdown
Contributor

Be-ing commented Feb 23, 2019

LGTM

@Be-ing Be-ing merged commit 30a4e7f into mixxxdj:master Feb 23, 2019
@Swiftb0y Swiftb0y mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Swiftb0y @daschuer @Be-ing