Skip to content

Don't use QStylePainter in WSpinny. lp:1530720 #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daschuer merged 2 commits into from
Jan 24, 2019
Merged

Don't use QStylePainter in WSpinny. lp:1530720 #1994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc6b594
Don't use QStylePainter in WSpinny. lp:1530720
rryan Dec 31, 2018
16478eb
Remove styling of WSpinny widgets. This should be a no-op.
rryan Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions res/skins/LateNight/style.qss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,6 @@ WTime {
border-right: 1px solid #585858;
}

WSpinny {/*
This produces artifacts in spinny bg
background-color: rgba(1, 1, 1, 10);
This makes no difference, the spinny loads some default grey bg
background: none;*/
}

#VisualizationContainer {
border: 1px solid #585858;
border-top: 0px;
Expand Down
6 changes: 1 addition & 5 deletions res/skins/Tango/style.qss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,10 +1907,6 @@ WTrackProperty#SamplerTitle_mini {
margin-right: 3px;
}

#SpinnyMini {
background-color: transparent;
}

/*################################################################
###### Preview Deck ##########################################
##############################################################*/
Expand Down Expand Up @@ -2338,7 +2334,7 @@ WLibrary QPushButton {
QPushButton#btnUnhide {
font-weight: bold;
}

/* 'Enable AutoDJ' button */
QPushButton#pushButtonAutoDJ:hover,
QPushButton#pushButtonRecording:hover,
Expand Down
5 changes: 1 addition & 4 deletions src/widget/wspinny.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,13 +318,10 @@ void WSpinny::render() {
&m_dGhostAngleCurrentPlaypos);
}

QStyleOption option;
option.initFrom(this);
QStylePainter p(this);
QPainter p(this);
p.setRenderHint(QPainter::Antialiasing);
p.setRenderHint(QPainter::HighQualityAntialiasing);
p.setRenderHint(QPainter::SmoothPixmapTransform);
p.drawPrimitive(QStyle::PE_Widget, option);

if (m_pBgImage) {
p.drawImage(rect(), *m_pBgImage, m_pBgImage->rect());
Expand Down