-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
remove autogenerated code from ChannelMixer #1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| #include "engine/channelmixer.h" | ||
|
|
||
| #include "util/sample.h" | ||
| #include "util/timer.h" | ||
|
|
||
| // static | ||
| void ChannelMixer::applyEffectsAndMixChannels(const EngineMaster::GainCalculator& gainCalculator, | ||
| QVarLengthArray<EngineMaster::ChannelInfo*, kPreallocatedChannels>* activeChannels, | ||
| QVarLengthArray<EngineMaster::GainCache, kPreallocatedChannels>* channelGainCache, | ||
| CSAMPLE* pOutput, | ||
| const ChannelHandle& outputHandle, | ||
| unsigned int iBufferSize, | ||
| unsigned int iSampleRate, | ||
| EngineEffectsManager* pEngineEffectsManager) { | ||
| // Signal flow overview: | ||
| // 1. Clear pOutput buffer | ||
| // 2. Calculate gains for each channel | ||
| // 3. Pass each channel's calculated gain and input buffer to pEngineEffectsManager, which then: | ||
| // A) Copies each channel input buffer to a temporary buffer | ||
| // B) Applies gain to the temporary buffer | ||
| // C) Processes effects on the temporary buffer | ||
| // D) Mixes the temporary buffer into pOutput | ||
| // The original channel input buffers are not modified. | ||
| SampleUtil::clear(pOutput, iBufferSize); | ||
| ScopedTimer t("EngineMaster::applyEffectsAndMixChannels"); | ||
| for (int i = 0; i < activeChannels->size(); ++i) { | ||
| EngineMaster::ChannelInfo* pChannelInfo = activeChannels->at(i); | ||
| EngineMaster::GainCache& gainCache = (*channelGainCache)[pChannelInfo->m_index]; | ||
| CSAMPLE_GAIN oldGain = gainCache.m_gain; | ||
| CSAMPLE_GAIN newGain; | ||
| if (gainCache.m_fadeout) { | ||
| newGain = 0; | ||
| gainCache.m_fadeout = false; | ||
| } else { | ||
| newGain = gainCalculator.getGain(pChannelInfo); | ||
| } | ||
| gainCache.m_gain = newGain; | ||
| pEngineEffectsManager->processPostFaderAndMix(pChannelInfo->m_handle, | ||
| outputHandle, | ||
| pChannelInfo->m_pBuffer, | ||
| pOutput, | ||
| iBufferSize, | ||
| iSampleRate, | ||
| pChannelInfo->m_features, | ||
| oldGain, | ||
| newGain); | ||
| } | ||
| } | ||
|
|
||
| void ChannelMixer::applyEffectsInPlaceAndMixChannels( | ||
| const EngineMaster::GainCalculator& gainCalculator, | ||
| QVarLengthArray<EngineMaster::ChannelInfo*, kPreallocatedChannels>* | ||
| activeChannels, | ||
| QVarLengthArray<EngineMaster::GainCache, kPreallocatedChannels>* | ||
| channelGainCache, | ||
| CSAMPLE* pOutput, | ||
| const ChannelHandle& outputHandle, | ||
| unsigned int iBufferSize, | ||
| unsigned int iSampleRate, | ||
| EngineEffectsManager* pEngineEffectsManager) { | ||
| // Signal flow overview: | ||
| // 1. Calculate gains for each channel | ||
| // 2. Pass each channel's calculated gain and input buffer to pEngineEffectsManager, which then: | ||
| // A) Applies the calculated gain to the channel buffer, modifying the original input buffer | ||
| // B) Applies effects to the buffer, modifying the original input buffer | ||
| // 4. Mix the channel buffers together to make pOutput, overwriting the pOutput buffer from the last engine callback | ||
| ScopedTimer t("EngineMaster::applyEffectsInPlaceAndMixChannels"); | ||
| SampleUtil::clear(pOutput, iBufferSize); | ||
| for (int i = 0; i < activeChannels->size(); ++i) { | ||
| EngineMaster::ChannelInfo* pChannelInfo = activeChannels->at(i); | ||
| EngineMaster::GainCache& gainCache = (*channelGainCache)[pChannelInfo->m_index]; | ||
| CSAMPLE_GAIN oldGain = gainCache.m_gain; | ||
| CSAMPLE_GAIN newGain; | ||
| if (gainCache.m_fadeout) { | ||
| newGain = 0; | ||
| gainCache.m_fadeout = false; | ||
| } else { | ||
| newGain = gainCalculator.getGain(pChannelInfo); | ||
| } | ||
| gainCache.m_gain = newGain; | ||
| pEngineEffectsManager->processPostFaderInPlace(pChannelInfo->m_handle, | ||
| outputHandle, | ||
| pChannelInfo->m_pBuffer, | ||
| iBufferSize, | ||
| iSampleRate, | ||
| pChannelInfo->m_features, | ||
| oldGain, | ||
| newGain); | ||
| SampleUtil::add(pOutput, pChannelInfo->m_pBuffer, iBufferSize); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider replacing with ranged-for, might result in some performance benefit even.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How could that provide a performance benefit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compilers may be able to optimize better when conveying the intent better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, currently
activeChannels->size()is probably called on every iteration while the ranged-for implementation would only compare the begin- and end-pointers of the iterator. I'm not saying this is a huge benefit, I just believe that we should do what compiler writers expect from us so we get better code and they can possibly produce better binaries.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability would benefit form a range based for loop. That's the main advantage, everything else is just bonus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be-ing#59