Merged
Conversation
… DE translation, nearly 100% translated. * At least on macOS, the incomplete translation was auto-selected, if the systems locale is DE. * Both translations share the same name in Mixxx Preferences > User Interface > Locale > German (Germany). Correct would be for DE = Deutsch, and for DE-DE = Deutsch (Deutschland) This issue is also with other translations, e.g. PT and PT-PT
Changed terminology (also in the Transifex DE-glossary):
* Artist = Künstler (was Interpret)
* Track = Track (was Titel).
Track is established in daily language use. This fixes some curious situations we had before, e.g. for source strings like "Track Title".
Also fixes several whitespace, punctuation, and consistency errors in the target language.
We should not call numbers here (was "4 or 8"), the description needs to be generic enough if a skin decided to show a different # of cues. We support 36 (afaik). Also the control does not affect the # of hotcues displayed in the waveforms. Current skins do need no update, since they display the number of hotcues they display in the controls label.
Member
|
LGTM, Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #1876
With regards to the double entries in the language selection menu, look like QT parses the language name from the file name. No matter the language node in the
*.tsfile or the content of the*.qrcfile.