Echo: double the maximum delay to 4 beats, one bar#1928
Echo: double the maximum delay to 4 beats, one bar#1928daschuer wants to merge 1 commit intomixxxdj:masterfrom
Conversation
|
I understand the desire for this, but I'm a bit wary of changing the behavior that users have gotten used to. What do others think? Do the benefits outweigh the cost here? |
| delay->setUnitsHint(EffectManifestParameter::UnitsHint::BEATS); | ||
| delay->setMinimum(0.0); | ||
| delay->setDefault(0.5); | ||
| delay->setMaximum(2.0); |
There was a problem hiding this comment.
This should actually become a preference setting. Extending the maximum range would not affect users that prefer to stick with the current, hard-coded default setting of 2 bars.
I mostly use the center position = 1 beat. Setting the knob to exactly 1 beat becomes much harder after this change. Much worse than that: After starting Mixxx the knob is still at the center position, i.e. now resulting in a 2 beat echo. Silently modifying existing settings is not acceptable.
There was a problem hiding this comment.
This should actually become a preference setting.
This will be possible after #1705 is merged with custom per-effect snapshots of parameter values and parameter ranges. Then we can set the absolute minimum and maximum values very wide (as wide as technically possible without breaking the logic of the DSP code) and ship Mixxx with narrowed ranges by default. I do not think we should hack a preference option for this one effect before that more general solution is available.
I mostly use the center position = 1 beat. Setting the knob to exactly 1 beat becomes much harder after this change.
IIRC this is why I chose 2 beats as the range in #1256.
|
might be an idea, to have a numerical display somewhere, saying what the knob is currently set to? |
We should do this, but that wouldn't solve the problems @uklotzde brought up. |
|
Considering the usability issues we discussed I'm voting against merging these changes. |
4 participants
this was requested here:
https://www.mixxx.org/forums/viewtopic.php?f=3&t=12319
And I think a bar echo is a reasonable feature.