Deere :: compact FX units

[ronso0]

This is an attempt to make the FX units a little more compact.
It's not polished yet. What do you think?

before:

.
now:

[daschuer]

Nice idea.

[ronso0]

expand toggle moved to the right, fixed FX controls layout.
at minimal size, with focus buttons:

[ronso0]

@Be-ing What do ou think about moving the Master FX buttons to the toolbar? And rearranging the mixer knobs a bit?
before:

after, #1848 merged:

[Be-ing]

Nice, I like this. I think it makes sense following our discussion on Zulip about the effects GUI.

What do ou think about moving the Master FX buttons to the toolbar? And rearranging the mixer knobs a bit?

Does it fit with the booth gain knob too? Regardless, it's a bit cluttered up there. It would help if we replaced the buttons with text, which takes up a lot of space, with icons.

[ronso0]

Does it fit with the booth gain knob too?

Not really, the center gap is about the same before/after. Labels get squeezed at minimal size..
As you may know I prefer icons over text, let's talk about that after #1848

[ronso0]

wookay, this is how it looks now.

Finally, compact units aren't stretching horizontally anymore when the opposing unit is expanded.
And I removed the META label, hope that's okay. It kinda felt obsolete since the label isn't there when the unit's collapsed, and Super/Mix don't have a label as well.

Please test!

[Be-ing]

Hmm... aesthetically something feels a bit odd about the collapsed view. Maybe try not having the expand button and the FX# label not on the same row?

And I removed the META label, hope that's okay.

Yes, thank you.

[ronso0]

Hmm... aesthetically something feels a bit odd about the collapsed view. Maybe try not having the expand button and the FX# label not on the same row?

I see what you mean. The label doesn't fit in between expand adn Pfl button, the unit would need to grow then. Or what do you have in mind?
I could try a border around the label, or group it with the expand toggle in another way:

[Be-ing]

How does it look with the expand button and headphone button side by side?

[ronso0]

How does it look with the expand button and headphone button side by side?

Will be tricky, they're differnetly sized. Also, the FX label is the header so it should stay at the top IMO

[ronso0]

The rules I try to follow:

• FX = header
• expand toggle sits in the top-right corner

So they could be grouped with a border like pictured above, or the expand toggle is stretched and includes the FX label:

[Be-ing]

Hm, that looks better, but I'm not certain it's what we should ultimately go with. Perhaps we can merge that and if we come up with better ideas later, open a new PR?

[ronso0]

Hm, that looks better, but I'm not certain it's what we should ultimately go with. Perhaps we can merge that and if we come up with better ideas later, open a new PR?

I agree. Will implement that later on.
For consistency the sampler expand toggle goes to the right, as well:

Only drawback: the Library expand toggle at the left looks kinda lost now. Should we move that to the right side of the search box?

[ronso0]

I just force-pushed to clean up the commits a bit:

• merge FX label expand toggle
• move sampler expand toggle
• move library expand toggle right nex to search bar

[ronso0]

@Be-ing Any objections? Ready to merge?

[Be-ing]

Something about the mix knob being adjacent to a rectangular button looks a little odd, but I think this does improve the design. Perhaps if you come up with an idea to improve that you can open a new PR.