solution win xp installation#1899
solution win xp installation#1899Be-ing merged 4 commits intomixxxdj:masterfrom legendary-acp:legendary-acp
Conversation
| Anyway, we display a warning message when installing on XP and below | ||
| Anyway, we display a warning message when installing on XP and below --> | ||
| <Condition Message="!(loc.OS2Old)"> | ||
| <![CDATA[Installed OR (VersionNT >= 501)]]> |
There was a problem hiding this comment.
change this too to 601 (windows 7) instead of 501.
Also, I just realized that we have to change the "OS2Old" message and translations in wix/Localization. We need to replace "Windows XP" for "Windows 7"
There was a problem hiding this comment.
Ok I'll update it
solution win xp installation
|
LGTM . Let's wait for what @rryan or the others say. |
|
Thanks for working on this. In the future, do not update translation files directly; update the translation template and ask for the template file to be pushed to Transifex, then update the translations on Transifex and pull the changes. I pushed the updated .po file translation template from this branch to Transifex. Now the translations have to be updated on Transifex for each language, otherwise, the next time someone pulls translations from Transifex for the Windows installer, the outdated translations that still say Windows XP will come back. |
|
Whoops, I realized after merging that this PR was targeted at master. I rebased it onto 2.2. |
…illing strings from translations memory. They were lost in a previous commit 343246a ``tx pull -r mixxxdj-windows-installer.mixxxpot -a --minimum-perc=1`` The template and the translations became out-of-sync, since a manual push to TF following mixxxdj#1899 I do not exactly know what the issue was, probably it does not work well that strings in the language files were manually changed, but not the timestamp. Anyway, now the template and the translations are n-sync again. Back to normal. In the future , we should NOT accept manual edits to translation files. Either use the TF online editor or one of the many available text translation softwares, see https://mixxx.org/wiki/doku.php/internationalization#offline_translation_software
3 participants
This pull request is for solving solution of installation in win xp.
Bug link: https://bugs.launchpad.net/mixxx/+bug/1772218
To solve this I uncommented the line mentioned in one of message in chat of above bug.