Fx selector: fix cut-off effect names in drop-down list for Linux#1596
Fx selector: fix cut-off effect names in drop-down list for Linux#1596ronso0 wants to merge 5 commits into
Conversation
| @@ -0,0 +1,10 @@ | |||
| /* hack around text getting cut off with scaled checkbox on Macs with Retina screens */ | |||
There was a problem hiding this comment.
This comment is confusing in style-linux.qss
There was a problem hiding this comment.
whoopsy..
anything else slipped through?
| background: #0081B7; | ||
| image: url(skin:/buttons/btn_fx_selector_tick.svg) no-repeat center center; | ||
| background: #0081B7; */ | ||
| } |
There was a problem hiding this comment.
I'll keep all those comments. Helpful, also it took quite a while to gather those infos..
|
What is the problem you are trying to solve with this? Testing on my 1366 x 768 laptop with KDE, the current 2.1 branch does not cut off effect names. But with this branch, every skin but Tango has effect names cut off on the left: |
Oblivion? #1590 (comment) Re Linux distros: interesting to see QAbstractItemView occupies the same width as the collapsed selector and expands downwards, while on xfce it expands beyond that and doesn't show scrollbars. |
|
It's quite frustrating that the QComboBox styling works so differently on each OS and even with different desktop environments (different Qt themes?). I guess we're running into a bug in QComboBox, but there's no way that's getting fixed for Qt4. I think we're going to have to adjust these styles all over again for 2.2 when switching to Qt5 anyway, so stressing out any more for perfection right now doesn't seem worth it IMO. Unfortunately I don't think there's a (reliable) way to detect different distros or Qt themes or whatever it is that's causing the styling heterogeneity and apply a different style... so I guess leave it how it is? 🤷♂️ |
I'm fine with that. |
|
Okay, thanks for trying. |
2 participants
Deere/LateNight: shift effect names left, tick mark still visible
Shade: shift effect names left, tick mark hidden
Tango: revert bg-color hack, bring back tick mark
Tested with Ubuntu 14.04 & Ubuntu Studio 14.04 (xfce session).
This fix is only necessary for a scale factor of 100%.
Above 100% works well, too, since the tick mark is not scaled anyway and therefore all effect names have more horizontal space.
Below 100% it seems to work, too, although thte tick mark is not scaled.
Please confirm this still looks good with KDE and other desktops