Add support for stem edit or update#15888
Conversation
|
Nice! |
|
Thanks for your feedback! Added the behaviour, as well as the DAO, proto and MP4 tags persistence. Screencast.From.2026-01-21.19-46-58.mp4Just testing is remaining. |
b053690 to
7982f2f
Compare
|
@JoergAtGithub any idea why the embedded taglib solution fails on Windows ARM? |
|
Does it link if you embedd the unmodified taglib? |
|
It works well on Windows 2022 x64 with the current version. I haven't had a chance to test further usecase on Windows machine and was wondering if this type error looked familiar and could maybe benefit from a quick fix |
|
Tried to get Windows ARM to use shared lining instead, but this seems to be a dead end. |
|
Note that we use still taglib 1.x on Windows, as there was a port overlay until mixxxdj/vcpkg#198 that overwrote the upstream version. |
987a050 to
606f759
Compare
|
Taglib 2.2 was announced with STEM support! |
|
Taglib 2.2beta got tagged. The usual beta period of taglib is 1 month, the changelog lists the 18th of Feb as release date. |
|
This now depends on VCPKG update: mixxxdj/vcpkg#209 |
e5fbbb7 to
cb718ef
Compare
|
This PR should now be ready to merge. One outstanding question is how to deal with the the required 2.2.0 TagLib version on Ubuntu. From @daschuer's comment on the SignalSmith Stretch PR, I understand we are not supposed to to download external libraries, does this mean we should not include this PR on Ubuntu? I could introduce a separate |
JoergAtGithub
left a comment
There was a problem hiding this comment.
Please move the commits with the VCPKG update to a separate PR! Updating dependencies and implementing a feature are two separate items that should be reviewed and tested independently.
|
Regarding the Ubuntu topic, the requirements are mostly defined in our Minimum Requirements Policy:
Means that a Leaving the policy aside, I agree that code with too many such macros is ugly and difficult to maintain. |
Not sure to understand why. I need the VCPKG update to confirm this features works, and updating VCPKG on its own could lead to it not working (as proven by the current state, which suggest I will need to release a new VCPKG build). Could you explain what value does this extra effort brings?
It also a massive blowback for Mixxx. As the reference for DJing on Linux and Ubuntu (and derivative) being the most popular distro, it feels like leaving users behind when it comes to stem generation (which this feature is a requirement for) is potentially bad press. I guess we could keep the "TagLib from Git" ON on release builds, and disable it (+macros) for PPA builds so we can still distribute Mixxx via Debian/Ubuntu PPA, and user who want to use advanced stem feature can install the |
|
Just realised that Fedora is also blocked on TagLib 1.13 ... |
a8ee149 to
8a5c1d0
Compare
8a5c1d0 to
31d656a
Compare
Add the ability for Mixxx to create/edit stem info. This will enable the creation of a new stem file.
Screencast.From.2026-01-21.02-32-08.mp4
DAO+proto for stem info is still todo.
Depends taglib/taglib#1299 and #16095
Closes #13710