Skip to content

chore(STEM): add a ALAC stem test file#15656

Merged
JoergAtGithub merged 2 commits into
mixxxdj:2.6from
acolombier:chore/add-window-test
Nov 23, 2025
Merged

chore(STEM): add a ALAC stem test file#15656
JoergAtGithub merged 2 commits into
mixxxdj:2.6from
acolombier:chore/add-window-test

Conversation

@acolombier
Copy link
Copy Markdown
Member

@acolombier acolombier commented Nov 22, 2025

FYI, this is how the file was generated, in order to be stricly equivalent to the existing AAC version (./src/test/stems/test.stem.mp4)

ffmpeg -i ./src/test/stems/test.stem.mp4 -map 0:0 -c:a alac main.m4a
ffmpeg -i ./src/test/stems/test.stem.mp4 -map 0:1 -c:a alac drum.m4a
ffmpeg -i ./src/test/stems/test.stem.mp4 -map 0:2 -c:a alac bass.m4a
ffmpeg -i ./src/test/stems/test.stem.mp4 -map 0:3 -c:a alac other.m4a
ffmpeg -i ./src/test/stems/test.stem.mp4 -map 0:4 -c:a alac vocal.m4a
docker run -v `pwd`:`pwd` -w `pwd` -it --rm aclmb/stemgen:main create \
    --mastered main.m4a \
    --drum drum.m4a \
    --bass bass.m4a \
    --other other.m4a \
    --vocal vocal.m4a \
    --codec alac \
    --drum-stem-color '#fd4a4a' \
    --bass-stem-color '#ffff00' \
    --other-stem-color '#00e8e8' \
    --vocal-stem-color '#ad65ff' \
    --other-stem-label Synths \
    --vocal-stem-label Vox \
    ./src/test/stems/test_alac.stem.mp4

Closes #15317 and #15384

@acolombier acolombier added this to the 2.6.0 milestone Nov 22, 2025
Copy link
Copy Markdown
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test on all platforms with both formats.

Comment thread src/test/stemcontrolobjecttest.cpp Outdated
Comment thread src/test/stemcontrolobjecttest.cpp Outdated
Comment thread .github/workflows/develop.yml Outdated
Comment thread src/test/stemcontrolobjecttest.cpp
@acolombier acolombier force-pushed the chore/add-window-test branch from 6f19cb5 to b6efa9d Compare November 23, 2025 15:47
Comment thread .github/workflows/checks.yml
@acolombier acolombier force-pushed the chore/add-window-test branch 2 times, most recently from 0944bfb to b6efa9d Compare November 23, 2025 17:24
Copy link
Copy Markdown
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 3a9c1c2 into mixxxdj:2.6 Nov 23, 2025
26 of 28 checks passed
daschuer added a commit to daschuer/mixxx that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants