chore: rename overly technical qml command argument#15596
Merged
Conversation
ronso0
reviewed
Nov 11, 2025
| "profile, or run with " | ||
| "'allow-dangerous-data-corruption-risk' to use " | ||
| "with the current one. We highly recommend " | ||
| "backing up you data if you do so.") |
Member
There was a problem hiding this comment.
Suggested change
| "backing up you data if you do so.") | |
| "backing up your data if you do so.") |
Member
|
what about |
Member
I have a déjà-vu 😅 See the discussion here: #15513 (comment) |
Member
Author
Member
Sure, makes sense. |
acolombier
force-pushed
the
chore/rename-qml-flag
branch
from
89e2a86 to
0eabd0f
Compare
Member
Author
|
Renamed the flag now. I took the freedom to amend directly so this can be merged directly |
Member
Author
|
@ronso0 happy to merge? |
ronso0
approved these changes
Nov 22, 2025
Member
|
Yep, LGTM. |
Member
|
@acolombier Why you added "needs testing" and "needs review" to this PR? What needs to be done here? |
Member
Author
|
I batch updated all QML PR ready to be reviewed and merged, I think this one is ready to just being merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #15437