Show hotcue info in tool tip#15471
Conversation
37ad2b1 to
69d4474
Compare
|
Please squash the commits, all coomits should build on all platforms (in case we need to |
|
I think rather than having another delegate, it'd better to have this in This would allow more flexibility, like easily change for which columns to show the tooltip. |
Good thinking, i first started with a class ComposeHotCueTooltip and then reverted to titledelegate ;-) (stupidissimo mi). |
Hmm, I don't need it but I see it can be helpful.
So [type] and [Color] can be removed IMO. Idea: if Cue is on a hocue, add [Cue] or something to indicate that? |
Now it feels like hijacking somebody else's idea.
Well, I want to see that info especially as some hotcue icons (loop & jump) are not clear cisible at a distance.
The problem: the tracklist is cached, new created hotcues aren't directly in the overview, vreating a new hotcue and sending a signal to (kind of) highlight / indicate the actual hotkeyposition (if any) can result in nothing. The first objective wa to have a difference between tracks with / without hotcues, |
|
Hmm, are color names really that helpful? |
e8d190b to
ea06406
Compare
Thanks, I didn't think of that, great help. |
86e21a9 to
3b86fd7
Compare
Show colours with html Fix hotcue # Fix loop
3b86fd7 to
2d94a1c
Compare
|
Shouldn't the loop duration be displayed in beats instead of time? |
| return formatHotCueTooltip(columnValue, hotCues, sampleRate); | ||
| } | ||
|
|
||
| QString BaseTrackTableModel::formatHotCueTooltip(const QString& columnValue, |
There was a problem hiding this comment.
I think we can merge all hotcue tooltip methods into composeHotCueTooltip()
There was a problem hiding this comment.
The idea was to have clear code and maybe have future other formatting functions.
| QString tooltip; | ||
|
|
||
| // Start HTML | ||
| tooltip += "<html><body style='white-space: pre; font-family: monospace; font-size: 15pt;'>"; |
There was a problem hiding this comment.
A monospace font and hard-coded font size will make the tooltip inconsistent with other tooltips (using the skin font).
I guess you chose monospace to get the [type] aligned? If yes, is this really an issue?
It'll only be slightly off if we have hoctue > 9
Last resort: create a html table?
There was a problem hiding this comment.
yes, that was the idea,
as you know (I wrote it before): I'm not a designer/css/qss/specialist, I try to create mathematical-visual correct things. My graphics-inspiration & insight isn't like yours.
I created different views (with a coloured square etc) and for me the 'clear, clean aligned coloured lines' are working best (tested from distance like in a live situation).
At a certain point I know my knowledge/insight/ambition/inspiration/interest stops with 'this is how I wanted/meant/want to use it', while there could definitely things be improved to get it 'in-line' with eg the design of other things.
Design/layout things probably take me 2/3/4/.. times more then it would take others (and it still wouldn't be of the same quality).
So if it comes to design/layout ... I'd be happy to hand over this baby for adoption, instead of having long discussions about formatting/fonts...
| 16, | ||
| QChar('0')) | ||
| .toUpper(); | ||
| cueLine = QString("<span style='color: %1;'>%2</span>").arg(hexColor, cueLine); |
There was a problem hiding this comment.
I don't think coloring the entire line is a good idea. We may have dark hotcue colors and those are hard to read in skins with dark background.
Did you try the colore square?
We may even try colored square with the hotcue number in it (contrasting color) so it looks like the buttons and waveforms marks.
| default: | ||
| typeString = "Unknown"; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Let's please stick to hotcues. Intro/outro/fisrt sound is just noise IMO
|
With 2e789bb I get this: 4 is actually a saved loop 🤔 |
Co-authored-by: ronso0 <ronso0@mixxx.org>
Co-authored-by: ronso0 <ronso0@mixxx.org>
|
Nice idea, but as I wrote: I don't have the graphivcal inspiration that brings me those ideas. |
Adding the beats is certainly an option, but:
|
Sure, that's why we collaborate, right?
I opened the screen shot and stepped back, and I can't read the blue hotcue line and aI have trouble with the red and purple hotcue. |
|
Ah srry, I thought you fluently wrote those style things, like 'freehand painting', I had no idea you had to look them up. ;-)
ah that's not good, needs to be solved :-( |
I think the issues is that CueDAO is not refreshed as frequently as the Tracks. |
.. and passing commits around. Sure. I managed to align cue properties with a html table. Looks good I think. Shall I push to your branch or continue in a separate branch? |
table looks good indeed, I can't see the icons, #7 in the image in description = jump cue and type is shown as jump cue.
be my guest, do as you like/prefer ;-) |
You're the King! |
Naa, I just checked where WHotcueButton and CueControl get their cues from ; ) Will open a PR soon. |
Well I was crashing my brains to find a solution that was quite obvious |
|
Here's my version #15484 |
|
This PR is marked as stale because it has been open 90 days with no activity. |




I did not want to hijack @mxmilkiib' PR #15462 / Idea / .... but it was turning in my head around and around so it had to get out.
I'm using the knowledge learned with the genrefeature and rconverting the idea of the genreDao to cueDAO.
At the moment the hotcue-overview is in the title-tooltip, but it can be placed in the tooltip of another (single/plural) field.
As the original idea was to show the # of hotcues, that isn't enough for me, I'd like to have an overview of the hotcues
**Number (presented like the hotcuebutton - position - label - type (duration if type is loop) *
Thank you @ronso0 for the presentation like a hotcuebutton (number & colour).
The only problem I still need to solve is the caching., but I this is a bigger problem.
For searchCrates (and other features) I add an bypassing exception in basesqltablemodel->select, but I'm wondering if we still need the caching/temporary tables intermediate.
The original caching was a solution for slower machines, but there was some evolution :-)
The colour indication (writing colournames) is based on the default hotcuecolours (but can be expanded of course)