(fix) Avoid engine freeze when loading a new track while scratching with waveform or spinny#15086
Merged
Merged
Conversation
Swiftb0y
approved these changes
Jul 12, 2025
Member
Swiftb0y
left a comment
There was a problem hiding this comment.
Code LGTM. No testing done though.
…ith waveform or spinny
e24e599 to
18f89d2
Compare
Member
Author
|
Thanks for taking a look! I tweaked it a bit (avoid the potential double call in And I added repro steps to the description. |
daschuer
approved these changes
Jul 16, 2025
Member
daschuer
left a comment
There was a problem hiding this comment.
LGTM and the issue is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15082
As proposed there, reset PositionScratchController on track load:
[ChannelN],scratch_position_enablem_inertiaEnabledandm_isScratchingm_rateHow to reproduce / confirm the fix:
Waveform and spinny would still show the drag cursor (hand) but moving it would not scratch.
Though this minor inconvenience is negligible IMO.