ci(2.5): remove all VCPKG_DEFAULT_HOST_TRIPLET entries from build.yml#15029
Merged
daschuer merged 1 commit intoJun 28, 2025
Merged
Conversation
daschuer
approved these changes
Jun 28, 2025
Member
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
LGTM, Thank you for taking care.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unused
-DVCPKG_DEFAULT_HOST_TRIPLETflags from the.github/workflows/build.ymlfile.These flags were previously set in the CMake arguments, but are no longer used by the Mixxx build system. They were triggering CMake warnings like:
Manually-specified variables were not used by the project:
VCPKG_DEFAULT_HOST_TRIPLET
Removing them simplifies the workflow configuration and eliminates unnecessary warnings during CI runs.
Fixes: #15022
@daschuer Kindly review this.