Skip to content

fix(stem): improve waveform channel visibility#14951

Merged
JoergAtGithub merged 1 commit into
mixxxdj:2.6from
acolombier:fix/improve-stem-waveform-channel-visibility
Jun 28, 2025
Merged

fix(stem): improve waveform channel visibility#14951
JoergAtGithub merged 1 commit into
mixxxdj:2.6from
acolombier:fix/improve-stem-waveform-channel-visibility

Conversation

@acolombier
Copy link
Copy Markdown
Member

@acolombier acolombier commented Jun 16, 2025

This improves customisation of the stem waveform visibility. This feature will allow opacity customisation, as well as bringing the last adjusted stem on foreground for better visibility

This should fix #14870

@acolombier acolombier force-pushed the fix/improve-stem-waveform-channel-visibility branch from 5d1000a to e7ab58f Compare June 16, 2025 22:26
@acolombier acolombier changed the base branch from main to 2.6 June 17, 2025 00:22
@acolombier acolombier added this to the 2.6.0 milestone Jun 17, 2025
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, rest looks sensible

Comment thread src/waveform/renderers/allshader/waveformrendererstem.h Outdated
Comment thread src/waveform/renderers/allshader/waveformrendererstem.h
Comment thread src/waveform/renderers/allshader/waveformrendererstem.cpp Outdated
Comment thread src/waveform/renderers/allshader/waveformrendererstem.h Outdated
@Swiftb0y
Copy link
Copy Markdown
Member

Code looks very good, but since this involves UX, I'd live to get @ronso0's thoughts too.

Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more nits

Comment thread src/waveform/renderers/allshader/waveformrendererstem.cpp Outdated
Comment thread src/waveform/waveformwidgetfactory.cpp
Comment thread src/waveform/waveformwidgetfactory.cpp
Comment thread src/waveform/renderers/allshader/waveformrendererstem.cpp
Comment thread src/waveform/waveformwidgetfactory.cpp
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you. /softfix

@Swiftb0y
Copy link
Copy Markdown
Member

/softfix

@acolombier
Copy link
Copy Markdown
Member Author

acolombier commented Jun 20, 2025

Sadly, I broke softfix. I'm just looking at the action in @daschuer's repo - Daniel, would you be open with me capturing this script directly inside the action so it easier to manage? It would go inside a dedicated .github/actions folder so would still be nicely encapsulated.

(FYI, The hardcoded use of GITHUB_TOKEN is the root cause of the problem)

@daschuer
Copy link
Copy Markdown
Member

My idea is to keep it reusable for all our repositories. So the logical move would be cloning it into mixxxdj.
I suggest to clone from upstream rather than from mine. Than I can make mine following mixxxdj.

@acolombier
Copy link
Copy Markdown
Member Author

acolombier commented Jun 20, 2025

After consideration, I've decided to stick with the existing action. I think we might want to move it inside Mixxx org at some point later, but don't have time now.
I took the freedom to push a oneliner to the CI to address this. a fix for my breaking change merged yesterday

@acolombier
Copy link
Copy Markdown
Member Author

/softfix

@Swiftb0y
Copy link
Copy Markdown
Member

still borked @acolombier ...

@acolombier
Copy link
Copy Markdown
Member Author

/softfix

@github-actions github-actions Bot force-pushed the fix/improve-stem-waveform-channel-visibility branch from ae09d93 to 07e8b85 Compare June 21, 2025 10:56
@acolombier acolombier force-pushed the fix/improve-stem-waveform-channel-visibility branch from 07e8b85 to ae09d93 Compare June 21, 2025 10:58
@github-actions github-actions Bot force-pushed the fix/improve-stem-waveform-channel-visibility branch from ae09d93 to 4a57f78 Compare June 21, 2025 11:08
@acolombier
Copy link
Copy Markdown
Member Author

I'm giving up. I consider this GH script too much of a hack and too hard to maintain. Happy to help moving this into the Mixxx repo, and migrate as an organisation action once it gets stabilised, in case you change your mind @daschuer

@acolombier acolombier force-pushed the fix/improve-stem-waveform-channel-visibility branch from 4a57f78 to 1efd45f Compare June 21, 2025 11:31
@acolombier
Copy link
Copy Markdown
Member Author

Rebased manually now @Swiftb0y

@Swiftb0y
Copy link
Copy Markdown
Member

Thanks.

Copy link
Copy Markdown
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it, and it works as intended.

@JoergAtGithub JoergAtGithub merged commit 280d711 into mixxxdj:2.6 Jun 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STEMS waveforms: increase opacity of switched off channels

4 participants