fix(stem): improve waveform channel visibility#14951
Conversation
5d1000a to
e7ab58f
Compare
Swiftb0y
left a comment
There was a problem hiding this comment.
couple nits, rest looks sensible
|
Code looks very good, but since this involves UX, I'd live to get @ronso0's thoughts too. |
|
/softfix |
|
Sadly, I broke softfix. I'm just looking at the action in @daschuer's repo - Daniel, would you be open with me capturing this script directly inside the action so it easier to manage? It would go inside a dedicated (FYI, The hardcoded use of GITHUB_TOKEN is the root cause of the problem) |
|
My idea is to keep it reusable for all our repositories. So the logical move would be cloning it into mixxxdj. |
|
After consideration, I've decided to stick with the existing action. I think we might want to move it inside Mixxx org at some point later, but don't have time now. |
|
/softfix |
|
still borked @acolombier ... |
|
/softfix |
ae09d93 to
07e8b85
Compare
07e8b85 to
ae09d93
Compare
ae09d93 to
4a57f78
Compare
|
I'm giving up. I consider this GH script too much of a hack and too hard to maintain. Happy to help moving this into the Mixxx repo, and migrate as an organisation action once it gets stabilised, in case you change your mind @daschuer |
4a57f78 to
1efd45f
Compare
|
Rebased manually now @Swiftb0y |
|
Thanks. |
JoergAtGithub
left a comment
There was a problem hiding this comment.
I just tested it, and it works as intended.
This improves customisation of the stem waveform visibility. This feature will allow opacity customisation, as well as bringing the last adjusted stem on foreground for better visibility
This should fix #14870