Don't try localeFromXkbSymbol w/o __X11__ defined#14949
Conversation
Because X11/XKBlib.h is a part of libX11 Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
|
What situation does this fix? Some sort of wayland-only configuration perhaps? |
|
Exactly, any system without libX11. |
Swiftb0y
left a comment
There was a problem hiding this comment.
I mean this probably breaks a bunch of locale-specific stuff, but that doesn't work properly anyways...
|
I think libxkbcommon could support x11/wayland. |
|
Qt has probably also improved since this code was written, it would be worth trying to figure out if we can reduce some of the platform dependent stuff. |
Nope, this is one of the recent keyboard fixes #14883 that actually make it work ; ) |
|
ifdefs LGTM btw |
Because X11/XKBlib.h is a part of libX11
That's a kind of fix-on-merge, because the workaround initially targeted 2.5 which do not define
__X11__.