Loopescape Test Fix

[daschuer]

Try to fix the test fails reported in #1487 (comment)

[uklotzde]

Still failing with a rounding error:

The difference between 200 and m_pChannel1->getEngineBuffer()->m_pLoopingControl->getCurrentSample() is 1, which exceeds kLoopPositionMaxAbsError, where
200 evaluates to 200,
m_pChannel1->getEngineBuffer()->m_pLoopingControl->getCurrentSample() evaluates to 199, and
kLoopPositionMaxAbsError evaluates to 1.0000000000000001e-09.
src/test/looping_control_test.cpp:554: Failure
The difference between 200 and m_pChannel1->getEngineBuffer()->m_pLoopingControl->getCurrentSample() is 1, which exceeds kLoopPositionMaxAbsError, where
200 evaluates to 200,
m_pChannel1->getEngineBuffer()->m_pLoopingControl->getCurrentSample() evaluates to 199, and
kLoopPositionMaxAbsError evaluates to 1.0000000000000001e-09.

[daschuer]

Strange. Is this probably caused by this commit: af218bc ?
It looks like there is some unintended remaining integer rounding in place, which looses one sample. Maybe because the rounding error in the previous test. If this where an intentional rounding, it should probably round to an even value.

[uklotzde]

@daschuer If I revert this commit the test succeeds.

[daschuer]

I have got it. A "real" bug: seekInsideAdjustedLoop() has truncated the result to an int. Fixed.

[uklotzde]

LGTM 👍 Waiting for the build server to finish.