(fix/feat) Traktor Kontrol S4 Mk3: tempo offset per deck#14882
Merged
Conversation
ronso0
commented
May 31, 2025
acolombier
approved these changes
Jun 11, 2025
Member
acolombier
left a comment
acolombier
left a comment
There was a problem hiding this comment.
This is looking, just a small suggestion!
acolombier
force-pushed
the
2.5
branch
2 times, most recently
from
cd725b1 to
d7d5934
Compare
ronso0
force-pushed
the
s4-tempo-offset-per-deck
branch
from
0aa1394 to
8442a16
Compare
Member
Author
|
I picked f2c1091 and tweaked it a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st is a fixup for #14721 (tempo center offset was missing factor ticks/mm)
2nd allows to set the offset per side