Deere: enabled "shadow position feature" for preview + samplers#1488
Deere: enabled "shadow position feature" for preview + samplers#1488Be-ing merged 3 commits intomixxxdj:2.1from
Conversation
|
This feature is also missing in the samplers I tried to add "PlayedOverlayColor" to @ronso0 any idea why? like this: <Overview>
<TooltipId>waveform_overview</TooltipId>
<Group><Variable name="group"/></Group>
<SizePolicy>me,me</SizePolicy>
<BgColor></BgColor>
<PlayedOverlayColor>#88000000</PlayedOverlayColor>
<SignalHighColor>#FFE300</SignalHighColor>
<SignalMidColor>#0099FF</SignalMidColor>
<SignalLowColor>#FF0035</SignalLowColor>
<SignalRGBHighColor></SignalRGBHighColor>
<SignalRGBMidColor></SignalRGBMidColor>
<SignalRGBLowColor></SignalRGBLowColor>
<SignalColor>#FF8000</SignalColor>
<PlayPosColor>#00FF00</PlayPosColor>
<DefaultMark>
<Align>bottom</Align>
<Color>#00FF00</Color>
<TextColor>#FFFFFF</TextColor>
<Text> %1 </Text>
</DefaultMark>
<MarkRange>
<StartControl>loop_start_position</StartControl>
<EndControl>loop_end_position</EndControl>
<EnabledControl>loop_enabled</EnabledControl>
<Color>#00FF00</Color>
<DisabledColor>#FFFFFF</DisabledColor>
</MarkRange>
<Mark>
<Control>cue_point</Control>
<Align>top</Align>
<Color>#FF001C</Color>
<TextColor>#FFFFFF</TextColor>
<Text>C</Text>
</Mark>
<Connection>
<ConfigKey><Variable name="group"/>,playposition</ConfigKey>
<EmitOnDownPress>false</EmitOnDownPress>
</Connection>
</Overview>``` |
|
Add Looks like parts of |
|
thanks @esbrandt |
the whole file sampler_overview_row.xml is unused! If I delete this file, and reload the skin there is NO change... this file was last changed by @Be-ing in #940 In https://github.com/mixxxdj/mixxx/blob/2.1/res/skins/Deere/sampler.xml the file sampler_overview_row.xml is no longer used, this was changed by @Be-ing 728c06c#diff-6ac4554c9d507ce52e901ebcede22be2 sampler_overview_row.xml is not used in anther file as the following command shows: /mixxx/res/skins/Deere $ grep -Ril "sampler_overview_row" ./
I suggest to delete "sampler_overview_row.xml " |
|
BTW: I am done with this PR, ready to merge in my opinion |
|
LGTM. @Be-ing, merge? |
|
Thanks for implementing this and cleaning up the old file. |


add PlayedOverlayColor to preview

(used same color as in https://github.com/mixxxdj/mixxx/blob/2.1/res/skins/Deere/left_gutter.xml for deck1/2)
before:
after:
