Fix learning with "No Mapping" selected#14829
Merged
Merged
Conversation
github-actions
Bot
added
controller mappings
library
engine
rekordbox
controller backend
developer experience
daschuer
added
regression
and removed
controller mappings
library
engine
rekordbox
developer experience
ronso0
reviewed
May 22, 2025
Comment on lines
+514
to
+519
| // Note: this is called by closeDlg() when MIDI learning starts | ||
| // "No Mapping" is selected but we have a mapping for learning | ||
| if (m_ui.comboBoxMapping->currentIndex() > kNoMappingIndex || !m_pMapping) { | ||
| // Force updating the controller settings | ||
| slotMappingSelected(m_ui.comboBoxMapping->currentIndex()); | ||
| } |
Member
There was a problem hiding this comment.
Good catch!
I was puzzled what was calling showMapping() and that's it.
ronso0
approved these changes
May 22, 2025
Member
ronso0
left a comment
ronso0
left a comment
There was a problem hiding this comment.
Looks and works good, thank you!
Member
|
pre-commit is not run for some reason, but it passes locally 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression since #11300 slipped through beta phase.