QML: controllers settings#14697
Conversation
6d60804 to
1475706
Compare
Swiftb0y
left a comment
There was a problem hiding this comment.
also couple thoughts, not a fully review though
1475706 to
7c166da
Compare
7c166da to
9724bea
Compare
9724bea to
8e3e57b
Compare
|
No doubt that this will need more polishing to consider it production ready, but I'd like to get this first batch polished and out now! |
This is licensed under CC. It comes from here. I have only reduced the resolution and truncated the shadow. From what I can see, only issues could be with the Just to compare, adding a visual really lift up the UX IMHO, thus why I really would like to find a solution to bundle visuals. |
ed6128d to
1601acd
Compare
The picture on wikimedia is obviously a copy of the official product picture from https://www.native-instruments.com/fileadmin/ni_media/dj/Traktor_Kontrol_S5/images/TRAKTOR_KONTROL_S2_MK3_website_comparison_chart_S4.png but it's marked as "own work". Every light and reflection is the same. |
|
It would be legally completely ok, if you take a photo of your own controller in a slightly different setting and upload it instead! |
1601acd to
89d2c6e
Compare
Okay, I've done just that. It's not pretty but we could always improve later, with a better picture. |
Thank you! I'm sorry, that I had to intervene here, and to block what was the visually much more appealing solution.
d9e9acc to
982902d
Compare
6c83efa to
6d35d6d
Compare
6d35d6d to
9b9f25c
Compare
|
I appreciate this PR is likely too big to be reviewed, but I'd like to find a solution to at least merge the part under |
9b9f25c to
11e4603
Compare
11e4603 to
583a7bc
Compare
cfff9db to
9f6801c
Compare
9f6801c to
2ab22a8
Compare
|
This PR should now be ready and the next one to focus on as part of the QML effort. |
JoergAtGithub
left a comment
There was a problem hiding this comment.
QML does not start up at all with this PR:
warning [Main] file:///D:/mixxx/res/qml/main.qml:641:5: Type Skin.Settings unavailable
warning [Main] file:///D:/mixxx/res/qml/Settings.qml:281:21: Type Settings.Controller unavailable
warning [Main] file:///D:/mixxx/res/qml/Settings/Controller.qml:4:1: Cannot load library D:\mixxx\build\x64__portable\Qt6\qml\QtQuick\Dialogs\qtquickdialogsplugin.dll: Das angegebene Modul wurde nicht gefunden.
critical [Main] Failed to load QML file "D:/mixxx/res/qml/main.qml"
|
Not entirely sure what is wrong. The DLL is there and correctly installed. I assume referenced DLL are missing, but not sure how to find this out |
|
I believe I might have fixed it, but not entirely sure, could you give it another go please? |


Point n click to come in a separate PR
Depends on #14606
Partially fixes #14538
TODO: