Skip to content

QML: controllers settings#14697

Open
acolombier wants to merge 5 commits intomixxxdj:mainfrom
acolombier:feat/qml-settings-controllers
Open

QML: controllers settings#14697
acolombier wants to merge 5 commits intomixxxdj:mainfrom
acolombier:feat/qml-settings-controllers

Conversation

@acolombier
Copy link
Copy Markdown
Member

@acolombier acolombier commented Apr 25, 2025

Point n click to come in a separate PR

Depends on #14606

Partially fixes #14538

TODO:

  • View reset is too slow
  • Don't use grid and make design responsive
  • Scroll the whole view to improve small device experience

@github-actions github-actions Bot added controller mappings packaging controller backend developer experience Issues, bugs and PRs related to the development process, development environment & developer docs labels May 4, 2025
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 6d60804 to 1475706 Compare May 5, 2025 01:07
Copy link
Copy Markdown
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also couple thoughts, not a fully review though

Comment thread src/util/singleton.h
Comment thread src/controllers/legacycontrollersettings.h
Comment thread src/controllers/controllermappinginfo.h Outdated
Comment thread s4_mk3.png Outdated
Comment thread res/controllers/Dummy Device Screen.hid.xml Outdated
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 1475706 to 7c166da Compare May 9, 2025 19:19
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 7c166da to 9724bea Compare May 18, 2025 23:40
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 9724bea to 8e3e57b Compare May 28, 2025 19:03
@acolombier
Copy link
Copy Markdown
Member Author

No doubt that this will need more polishing to consider it production ready, but I'd like to get this first batch polished and out now!

@acolombier acolombier marked this pull request as ready for review May 28, 2025 19:04
Copy link
Copy Markdown
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyrighted image res/qml/images/controllers/ni_traktor_s4_mk3.png needs to be removed!
And the CI must be Pass of course.

@acolombier
Copy link
Copy Markdown
Member Author

acolombier commented May 29, 2025

The copyrighted image res/qml/images/controllers/ni_traktor_s4_mk3.png needs to be removed!

This is licensed under CC. It comes from here. I have only reduced the resolution and truncated the shadow. From what I can see, only issues could be with the attribution clause. Are you okay if I put a LICENSE file under res/qml/images/controllers which provides details for this? THis can then be used to referenced different license used by multiple visual (obviously we would only accept CC-compatible licenses)

Just to compare, adding a visual really lift up the UX IMHO, thus why I really would like to find a solution to bundle visuals.
image
image

@acolombier acolombier force-pushed the feat/qml-settings-controllers branch 3 times, most recently from ed6128d to 1601acd Compare May 29, 2025 12:11
@JoergAtGithub
Copy link
Copy Markdown
Member

The copyrighted image res/qml/images/controllers/ni_traktor_s4_mk3.png needs to be removed!

This is licensed under CC. It comes from here. I have only reduced the resolution and truncated the shadow. From what I can see, only issues could be with the attribution clause. Are you okay if I put a LICENSE file under res/qml/images/controllers which provides details for this? THis can then be used to referenced different license used by multiple visual (obviously we would only accept CC-compatible licenses)

The picture on wikimedia is obviously a copy of the official product picture from https://www.native-instruments.com/fileadmin/ni_media/dj/Traktor_Kontrol_S5/images/TRAKTOR_KONTROL_S2_MK3_website_comparison_chart_S4.png but it's marked as "own work". Every light and reflection is the same.
Unless we have a written permission from Native Instruments, we must not use it! Maybe Native Instruments has general terms for the use of product picture by dealers etc., that also allows this use?
In any way, our Contributor Aggreement mandates that any contribution "includes complete details of any third-party license or other restriction".

@JoergAtGithub
Copy link
Copy Markdown
Member

It would be legally completely ok, if you take a photo of your own controller in a slightly different setting and upload it instead!

@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 1601acd to 89d2c6e Compare May 29, 2025 12:52
@acolombier
Copy link
Copy Markdown
Member Author

It would be legally completely ok, if you take a photo of your own controller in a slightly different setting and upload it instead!

Okay, I've done just that. It's not pretty but we could always improve later, with a better picture.

@JoergAtGithub JoergAtGithub dismissed their stale review May 29, 2025 13:00

Thank you! I'm sorry, that I had to intervene here, and to block what was the visually much more appealing solution.

@acolombier acolombier force-pushed the feat/qml-settings-controllers branch 4 times, most recently from d9e9acc to 982902d Compare May 30, 2025 10:21
@github-actions github-actions Bot added the developer experience Issues, bugs and PRs related to the development process, development environment & developer docs label Nov 23, 2025
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch 2 times, most recently from 6c83efa to 6d35d6d Compare November 24, 2025 01:20
@acolombier acolombier mentioned this pull request Nov 28, 2025
12 tasks
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 6d35d6d to 9b9f25c Compare December 6, 2025 14:43
@acolombier
Copy link
Copy Markdown
Member Author

I appreciate this PR is likely too big to be reviewed, but I'd like to find a solution to at least merge the part under src/controllers/ so it does get conflicted.

@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 9b9f25c to 11e4603 Compare January 10, 2026 23:41
@acolombier acolombier removed controller mappings build code quality packaging developer experience Issues, bugs and PRs related to the development process, development environment & developer docs labels Jan 10, 2026
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 11e4603 to 583a7bc Compare February 7, 2026 14:20
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch 2 times, most recently from cfff9db to 9f6801c Compare February 7, 2026 21:59
@acolombier acolombier force-pushed the feat/qml-settings-controllers branch from 9f6801c to 2ab22a8 Compare February 7, 2026 22:00
@github-actions github-actions Bot added the build label Feb 7, 2026
@acolombier
Copy link
Copy Markdown
Member Author

This PR should now be ready and the next one to focus on as part of the QML effort.

Copy link
Copy Markdown
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QML does not start up at all with this PR:

warning [Main] file:///D:/mixxx/res/qml/main.qml:641:5: Type Skin.Settings unavailable
warning [Main] file:///D:/mixxx/res/qml/Settings.qml:281:21: Type Settings.Controller unavailable
warning [Main] file:///D:/mixxx/res/qml/Settings/Controller.qml:4:1: Cannot load library D:\mixxx\build\x64__portable\Qt6\qml\QtQuick\Dialogs\qtquickdialogsplugin.dll: Das angegebene Modul wurde nicht gefunden.
critical [Main] Failed to load QML file "D:/mixxx/res/qml/main.qml"

@acolombier
Copy link
Copy Markdown
Member Author

acolombier commented May 4, 2026

Not entirely sure what is wrong. The DLL is there and correctly installed. I assume referenced DLL are missing, but not sure how to find this out

@acolombier
Copy link
Copy Markdown
Member Author

I believe I might have fixed it, but not entirely sure, could you give it another go please?

Comment thread CMakeLists.txt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build controller backend controller mappings developer experience Issues, bugs and PRs related to the development process, development environment & developer docs needs review needs testing packaging qml

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Settings -> Controllers

3 participants