remove effects and samplers toggles from View menu by Be-ing · Pull Request #1432 · mixxxdj/mixxx

Be-ing · 2017-12-21T02:18:49Z

These are available in skins. Defining the options in the View menu was getting in the way of skins showing effects and samplers by default.

uklotzde · 2017-12-21T07:30:49Z

Good idea. In full-screen mode I would even prefer if the top menu bar is invisible.

Just some thoughts:

"Options" in the top menu bar looks a bit odd. It contains items for very different aspects.
"Preferences" would also fit into "File": Rescan Library | ... | Preferences | Exit
Both "Load Track..." and ""Vinyl Control" are related to a "Deck"
Do we need the "Load Track ..." actions at all?
"Full Screen" is actually a "View" option
Keyboard shortcuts belong to the UI, though the general term "View" doesn't really fit here

Be-ing · 2017-12-21T09:18:06Z

In full-screen mode I would even prefer if the top menu bar is invisible.

Me too. I'd like to take it further and get rid of the menu bar entirely. But that's not happening in 2 days.

"Preferences" would also fit into "File": Rescan Library | ... | Preferences | Exit

👍

Both "Load Track..." and ""Vinyl Control" are related to a "Deck"

What are you suggesting? Adding a "Decks" menu? I would like to reduce the number of menus.

Do we need the "Load Track ..." actions at all?

I think we could get rid of them. A few times I have accidentally activated them and been annoyed by the file selection dialog popping up. Any objections?

"Full Screen" is actually a "View" option

Yes, but I don't want to have a View menu just for one item.

ronso0 · 2017-12-21T17:16:19Z

Do we need the "Load Track ..." actions at all?

I think we could get rid of them. A few times I have accidentally activated them and been annoyed by the file selection dialog popping up. Any objections?

Hm, I never actually used them. But in rare cases I'd consider them a fallback for loading tracks that aren't in the library but for example on a USB stick when you're not familiar with or currently not capable of ( 🍸 🍻 🍷 or jittery/unreliable touchpad) file drag'n'drop. In either case I wouldn't dive down the "My Computer" tree in the library

ronso0 · 2017-12-21T17:19:21Z

Some controls are not (yet) available in Shade: Cover Art, Preview deck :/

daschuer · 2017-12-21T18:08:20Z

It is no deal to add button for preview deck, and cover art into Shade.

Unfortunately this change also breaks various forum and legacy skins. So I like to delay this to 2.2.

In general, I consider the skin Menüs only as a workaround, because they are not well integrated into the OSs. Maybe with Qt5, we have the option to build rich Os integrated menus, replacing the tradition menu bar. In any case we have the chance to rethink this topic once we are on qt5.

Be-ing · 2017-12-21T19:03:02Z

Unfortunately this change also breaks various forum and legacy skins. So I like to delay this to 2.2.

Delaying this will not change that. IMO this must be done for the beta release because it is blocking the effects showing on first startup.

Be-ing · 2017-12-21T19:05:53Z

In general, I consider the skin Menüs only as a workaround, because they are not well integrated into the OSs. Maybe with Qt5, we have the option to build rich Os integrated menus, replacing the tradition menu bar. In any case we have the chance to rethink this topic once we are on qt5.

We should not have the same things in both the menu bar and the skin settings menus. We should pick one or the other and our skins have implemented quite comprehensive settings menus. We have a completely custom GUI with our skins, so I think integrating with the OS would actually be odd.

ronso0 · 2017-12-21T19:39:25Z

I'm not convinced yet that we need the same extensive menu in Shade and LateNight like we have it in Deere and Tango.
Let's just remove Effects and Samplers from the menu --toggles are available in all skins-- and not repeat the discussion from #927 and other PRs here (now) so that beta works fine, okay?

Be-ing · 2017-12-21T19:54:35Z

That's a workable compromise for me for now. But I think we should remove the menu bar entirely in the future. Getting rid of it for 2.2 when we introduce a nice new library GUI would make sense to me.

sblaisot · 2017-12-21T20:21:44Z

Application menu bar is translatable. Skin menu is not. So I vote to keep application menu bar until we have a solution.

sblaisot · 2017-12-21T20:23:24Z

And ronso0 proposition also seems a good compromise to me for the beta

Having those there was preventing effects and samplers being shown on first startup. All skins have toggles for these anyway.

Be-ing · 2017-12-22T02:36:38Z

Okay, compromise implemented. I tested starting Mixxx with a fresh profile and it shows Deere with effects and one row of samplers as desired.

daschuer · 2017-12-22T05:59:44Z

Thank you. LGTM

nopeppermint · 2017-12-29T13:17:48Z

I just opened a Bug on lunchpad (as this is not possible in your github repo..)
https://bugs.launchpad.net/mixxx/+bug/1740499
source of this usability bug is this PR

nopeppermint · 2017-12-29T13:25:01Z

    QMenu* pViewMenu = new QMenu(tr("&View"));

    QString mayNotBeSupported = tr("May not be supported on all skins.");
-    QString showSamplersTitle = tr("Show Samplers");


Why not introduce here a simple variable which tell if the current selected Skin has a "Show Samplers" Button or not, depending on that, show here this option, that would also solve @daschuer remark

Unfortunately this change also breaks various forum and legacy skins

new Skins which have those Buttons sets a variable and then the option is not visible in the menu, otherwise it is visible in the menu.

if(selected_skin.has_sample_button==0)
{
QString showSamplersTitle = tr("Show Samplers");
QString showSamplersText = tr("Show the sample deck section of the Mixxx interface.") +
" " + mayNotBeSupported;
auto pViewShowSamplers = new QAction(showSamplersTitle, this);
pViewShowSamplers->setCheckable(true);
pViewShowSamplers->setShortcut(
QKeySequence(m_pKbdConfig->getValue(ConfigKey("[KeyboardShortcuts]",
"ViewMenu_ShowSamplers"),
tr("Ctrl+1", "Menubar|View|Show Samplers"))));
pViewShowSamplers->setStatusTip(showSamplersText);
pViewShowSamplers->setWhatsThis(buildWhatsThis(showSamplersTitle, showSamplersText));
createVisibilityControl(pViewShowSamplers, ConfigKey("[Samplers]", "show_samplers"));
pViewMenu->addAction(pViewShowSamplers);
}

Unfortunately it is not that simple because the tangled initialization process makes things fragile. I would rather add toggles to Shade and work towards removing the menu bar entirely.

@nopeppermint would you like to add those buttons to Shade?

I may try to do this, if will try to add some kind of "extensive menu" as in deere/tango, thats seems to be the best solution for me

Shade has this button already.
The tiny text labels above the vu-meters.
They are not very usable though.

I am currently working on a Shade Skin that solved it. The concept will re-use the current looping region for basic quick access buttons for various features, and toggle buttons to open additional skin regions with fine access to each feature.

I am happy to have a helping hand for this. Unfortunately I have no access to my device with my work in progress Shade skin. I will publish it tomorrow.

nopeppermint · 2017-12-29T13:27:02Z

    createVisibilityControl(pViewShowPreviewDeck, ConfigKey("[PreviewDeck]", "show_previewdeck"));
    pViewMenu->addAction(pViewShowPreviewDeck);

-    QString showEffectsTitle = tr("Show Effect Rack");


same here for "Show Effect Rack":
if(selected_skin.has_sample_button==0)
{
QString showEffectsTitle = tr("Show Effect Rack");
QString showEffectsText = tr("Show the effect rack in the Mixxx interface.") +
" " + mayNotBeSupported;
auto pViewShowEffects = new QAction(showEffectsTitle, this);
pViewShowEffects->setCheckable(true);
pViewShowEffects->setShortcut(
QKeySequence(m_pKbdConfig->getValue(
ConfigKey("[KeyboardShortcuts]", "ViewMenu_ShowEffects"),
tr("Ctrl+5", "Menubar|View|Show Effect Rack"))));
pViewShowEffects->setStatusTip(showEffectsText);
pViewShowEffects->setWhatsThis(buildWhatsThis(showEffectsTitle, showEffectsText));
createVisibilityControl(pViewShowEffects, ConfigKey("[EffectRack1]", "show"));
pViewMenu->addAction(pViewShowEffects);
}

nopeppermint

add some ideas

remove effects and samplers toggles from View menu

0f3de2d

Having those there was preventing effects and samplers being shown on first startup. All skins have toggles for these anyway.

Be-ing force-pushed the simplify_menu_bar branch from e3603ff to 0f3de2d Compare December 22, 2017 02:35

Be-ing changed the title ~~remove redundant items from top menu bar~~ remove effects and samplers toggles from View menu Dec 22, 2017

daschuer merged commit 7d8bd5d into mixxxdj:master Dec 22, 2017

nopeppermint reviewed Dec 29, 2017

View reviewed changes

Be-ing added this to the 2.1.0 milestone Dec 29, 2017

Be-ing deleted the simplify_menu_bar branch December 29, 2017 16:23

mixxxbot mentioned this pull request Aug 24, 2022

Shade toggles for effects and samplers are hard to find #9028

Closed

Uh oh!

Conversation

Be-ing commented Dec 21, 2017

Uh oh!

uklotzde commented Dec 21, 2017

Uh oh!

Be-ing commented Dec 21, 2017

Uh oh!

ronso0 commented Dec 21, 2017

Uh oh!

ronso0 commented Dec 21, 2017

Uh oh!

daschuer commented Dec 21, 2017

Uh oh!

Be-ing commented Dec 21, 2017

Uh oh!

Be-ing commented Dec 21, 2017

Uh oh!

ronso0 commented Dec 21, 2017

Uh oh!

Be-ing commented Dec 21, 2017

Uh oh!

sblaisot commented Dec 21, 2017

Uh oh!

sblaisot commented Dec 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Be-ing commented Dec 22, 2017

Uh oh!

daschuer commented Dec 22, 2017

Uh oh!

nopeppermint commented Dec 29, 2017

Uh oh!

nopeppermint Dec 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Be-ing Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

Be-ing Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

nopeppermint Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

daschuer Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

daschuer Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

nopeppermint Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

nopeppermint left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sblaisot commented Dec 21, 2017 •

edited

Loading

nopeppermint Dec 29, 2017 •

edited

Loading