-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Create JavascriptPlayerProxy #14314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoergAtGithub
merged 3 commits into
mixxxdj:main
from
christophehenry:JavascriptPlayerProxy
Jun 20, 2025
Merged
Create JavascriptPlayerProxy #14314
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| #include "javascriptplayerproxy.h" | ||
|
|
||
| #include "moc_javascriptplayerproxy.cpp" | ||
|
|
||
| JavascriptPlayerProxy::JavascriptPlayerProxy(BaseTrackPlayer* pTrackPlayer, QObject* parent) | ||
| : QObject(parent), | ||
| m_pTrackPlayer(pTrackPlayer) { | ||
| if (m_pTrackPlayer && m_pTrackPlayer->getLoadedTrack()) { | ||
| slotTrackLoaded(pTrackPlayer->getLoadedTrack()); | ||
| } | ||
|
|
||
| connect(m_pTrackPlayer, | ||
| &BaseTrackPlayer::loadingTrack, | ||
| this, | ||
| &JavascriptPlayerProxy::slotLoadingTrack); | ||
| connect(m_pTrackPlayer, | ||
| &BaseTrackPlayer::newTrackLoaded, | ||
| this, | ||
| &JavascriptPlayerProxy::slotTrackLoaded); | ||
| connect(m_pTrackPlayer, | ||
| &BaseTrackPlayer::playerEmpty, | ||
| this, | ||
| [this]() { | ||
| disconnectTrack(); | ||
| emit trackUnloaded(); | ||
| }); | ||
| } | ||
|
|
||
| void JavascriptPlayerProxy::slotTrackLoaded(TrackPointer pTrack) { | ||
| m_pCurrentTrack = pTrack; | ||
| if (pTrack == nullptr) { | ||
| emit trackUnloaded(); | ||
| return; | ||
| } | ||
|
|
||
| connect(pTrack.get(), | ||
| &Track::artistChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::artistChanged); | ||
| connect(pTrack.get(), | ||
| &Track::titleChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::titleChanged); | ||
| connect(pTrack.get(), | ||
| &Track::albumChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::albumChanged); | ||
| connect(pTrack.get(), | ||
| &Track::albumArtistChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::albumArtistChanged); | ||
| connect(pTrack.get(), | ||
| &Track::genreChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::genreChanged); | ||
| connect(pTrack.get(), | ||
| &Track::composerChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::composerChanged); | ||
| connect(pTrack.get(), | ||
| &Track::groupingChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::groupingChanged); | ||
| connect(pTrack.get(), | ||
| &Track::yearChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::yearChanged); | ||
| connect(pTrack.get(), | ||
| &Track::trackNumberChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::trackNumberChanged); | ||
| connect(pTrack.get(), | ||
| &Track::trackTotalChanged, | ||
| this, | ||
| &JavascriptPlayerProxy::trackTotalChanged); | ||
|
|
||
| emit artistChanged(m_pCurrentTrack->getArtist()); | ||
| emit titleChanged(m_pCurrentTrack->getTitle()); | ||
| emit albumChanged(m_pCurrentTrack->getAlbum()); | ||
| emit albumArtistChanged(m_pCurrentTrack->getAlbumArtist()); | ||
| emit genreChanged(m_pCurrentTrack->getGenre()); | ||
| emit composerChanged(m_pCurrentTrack->getComposer()); | ||
| emit groupingChanged(m_pCurrentTrack->getGrouping()); | ||
| emit yearChanged(m_pCurrentTrack->getYear()); | ||
| emit trackNumberChanged(m_pCurrentTrack->getTrackNumber()); | ||
| emit trackTotalChanged(m_pCurrentTrack->getTrackTotal()); | ||
|
christophehenry marked this conversation as resolved.
|
||
| } | ||
|
|
||
| void JavascriptPlayerProxy::slotLoadingTrack(TrackPointer pNewTrack, TrackPointer pOldTrack) { | ||
| VERIFY_OR_DEBUG_ASSERT(pOldTrack == m_pCurrentTrack) { | ||
| qWarning() << "Javascript Player proxy was expected to contain " | ||
| << pOldTrack.get() << "as active track but got" | ||
| << m_pCurrentTrack.get(); | ||
| } | ||
|
|
||
| if (pNewTrack == m_pCurrentTrack) { | ||
| return; | ||
| } | ||
|
|
||
| disconnectTrack(); | ||
| m_pCurrentTrack = pNewTrack; | ||
| } | ||
|
|
||
| void JavascriptPlayerProxy::disconnectTrack() { | ||
| if (m_pCurrentTrack != nullptr) { | ||
| m_pCurrentTrack->disconnect(this); | ||
| } | ||
| } | ||
|
|
||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, artist, getArtist) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, title, getTitle) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, album, getAlbum) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, albumArtist, getAlbumArtist) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, genre, getGenre) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, composer, getComposer) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, grouping, getGrouping) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, year, getYear) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, trackNumber, getTrackNumber) | ||
| PROPERTY_IMPL_GETTER(JavascriptPlayerProxy, QString, trackTotal, getTrackTotal) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| #pragma once | ||
|
|
||
| #include "mixer/basetrackplayer.h" | ||
| #include "track/track.h" | ||
|
|
||
| #define PROPERTY_IMPL_GETTER(NAMESPACE, TYPE, NAME, GETTER) \ | ||
| TYPE NAMESPACE::GETTER() const { \ | ||
| const TrackPointer pTrack = m_pCurrentTrack; \ | ||
| if (pTrack == nullptr) { \ | ||
| return TYPE(); \ | ||
| } \ | ||
| return pTrack->GETTER(); \ | ||
| } | ||
|
|
||
| class JavascriptPlayerProxy : public QObject { | ||
| Q_OBJECT | ||
| Q_PROPERTY(QString artist READ getArtist NOTIFY artistChanged) | ||
| Q_PROPERTY(QString title READ getTitle NOTIFY titleChanged) | ||
| Q_PROPERTY(QString album READ getAlbum NOTIFY albumChanged) | ||
| Q_PROPERTY(QString albumArtist READ getAlbumArtist NOTIFY albumArtistChanged) | ||
| Q_PROPERTY(QString genre READ getGenre STORED false NOTIFY genreChanged) | ||
| Q_PROPERTY(QString composer READ getComposer NOTIFY composerChanged) | ||
| Q_PROPERTY(QString grouping READ getGrouping NOTIFY groupingChanged) | ||
| Q_PROPERTY(QString year READ getYear NOTIFY yearChanged) | ||
| Q_PROPERTY(QString trackNumber READ getTrackNumber NOTIFY trackNumberChanged) | ||
| Q_PROPERTY(QString trackTotal READ getTrackTotal NOTIFY trackTotalChanged) | ||
| public: | ||
| explicit JavascriptPlayerProxy(BaseTrackPlayer* pTrackPlayer, QObject* parent); | ||
|
|
||
| QString getTitle() const; | ||
| QString getArtist() const; | ||
| QString getAlbum() const; | ||
| QString getAlbumArtist() const; | ||
| QString getGenre() const; | ||
| QString getComposer() const; | ||
| QString getGrouping() const; | ||
| QString getYear() const; | ||
| QString getTrackNumber() const; | ||
| QString getTrackTotal() const; | ||
|
|
||
| public slots: | ||
| void slotTrackLoaded(TrackPointer pTrack); | ||
| void slotLoadingTrack(TrackPointer pNewTrack, TrackPointer pOldTrack); | ||
|
|
||
| signals: | ||
| void trackUnloaded(); | ||
| void albumChanged(QString newAlbum); | ||
| void titleChanged(QString newTitle); | ||
| void artistChanged(QString newArtist); | ||
| void albumArtistChanged(QString newAlbumArtist); | ||
| void genreChanged(QString newGenre); | ||
| void composerChanged(QString newComposer); | ||
| void groupingChanged(QString grouping); | ||
| void yearChanged(QString newYear); | ||
| void trackNumberChanged(QString newTrackNumber); | ||
| void trackTotalChanged(QString newTrackTotal); | ||
|
|
||
| protected: | ||
| void disconnectTrack(); | ||
| QPointer<BaseTrackPlayer> m_pTrackPlayer; | ||
| TrackPointer m_pCurrentTrack; | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.