Refactor passing of LegacyControllerMapping#14292
Merged
daschuer merged 5 commits intomixxxdj:2.5from Feb 7, 2025
Merged
Conversation
…ht have changed and otherwise the call would disconnect an no longer used mapping.
Swiftb0y
reviewed
Feb 4, 2025
Member
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
while the current solution does not really rectify the bad pre-established design, the changes seem reasonable.
Swiftb0y
approved these changes
Feb 4, 2025
Member
Author
|
CI is done. Thank you for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the groundwork of fixing #13940
It contains the confirmed refactoring form #14159
I have forked that out because the original crasher fix requires some more polishing.
It basically enforces that m_pMapping is unique by using a unique pointer instead of using an assertion on a shared pointer, which is not 100 % reliable in a multi-threading context.