do not adjust beatloop_size when pressing beatlooproll_X_activate by Be-ing · Pull Request #1428 · mixxxdj/mixxx

Be-ing · 2017-12-20T04:26:50Z

Fixing https://bugs.launchpad.net/mixxx/+bug/1721881

daschuer · 2017-12-20T07:31:30Z

    // Disregard existing loops.
    m_pSlipEnabled->set(1);
-    slotBeatLoop(pBeatLoopControl->getSize(), false, true);
+    slotBeatLoop(pBeatLoopControl->getSize(), false, true, false);


I think this requires some explainations, and the related use case.
Why you give a beat loop size on one hand an on the other hand the not adjust flag.

The beatlooproll_X_activate buttons are momentary use whereas beatloop_size is a more enduring value. @ronso0 reported it was unexpected and annoying that beatlooproll_X_activate changed beatloop_size and I think that makes sense.

daschuer · 2017-12-20T13:30:19Z

-    if (!m_pTrack || samples == 0
-            || !m_pBeats) {
+    if ((!m_pTrack || samples == 0 || !m_pBeats) && adjustBeatloopSizeCO) {
        clearActiveBeatLoop();


Is it correct to skip this as well?

Good point, no it is not. I'll just make the following line conditional for adjustBeatloopSizeCO.

ronso0 · 2017-12-21T15:55:53Z

Ready to test?

Be-ing · 2017-12-21T16:06:51Z

Yes.

ronso0 · 2017-12-21T17:05:30Z

Just tested this:

it's not changing beatlooop_size in the spinbox 👍
1/16 beatloop_roll only worked in 50% of tests, else it would just keep playing normally with an active loop in the waveforms 👎
when using a rolling beatloop it would highlight the loop button related to loop size in the spinbox, not the one of actual beatloop_roll size 😕 (Tango with beatloop grid open)
using beatloop_roll would leave it's loop_in/_out markers, so reloop would activate that rolling beatloop

3 would be nice-to-have
4 probably won't be solved here, this would require handling multiple loops

ronso0 · 2017-12-22T01:14:38Z

1/16 beatloop_roll only worked in 50% of tests, else it would just keep playing normally with an active loop in the waveforms

sorry, this also happens in master

Be-ing · 2017-12-22T03:35:28Z

Okay, then this is ready to merge.

when using a rolling beatloop it would highlight the loop button related to loop size in the spinbox, not the one of actual beatloop_roll size 😕 (Tango with beatloop grid open)

That would require adding beatlooproll_X_enabled Controls separate from beatloop_X_enabled, which is beyond the scope of this little PR.

daschuer · 2017-12-22T05:52:03Z

1/16 beatloop_roll only worked in 50% of tests, else it would just keep playing normally with an active loop in the waveforms

sorry, this also happens in master

Ups, that is probably related to my work here: #1367

daschuer · 2017-12-22T05:56:25Z

when using a rolling beatloop it would highlight the loop button related to loop size in the spinbox, not the one of actual beatloop_roll size 😕 (Tango with beatloop grid open)

This is IMHO blocking the merge, because we have beatloop roll on the right click of these buttons.

daschuer · 2018-03-22T07:10:36Z

Let's move this from the 2.1 milestone in favour of a consistent temporary rolling loop solution.
That is the requested feature and hacking around this may create other issues.

daschuer · 2018-09-20T06:23:34Z

1/16 beatloop_roll only worked in 50% of tests, else it would just keep playing normally with an active loop in the waveforms

Do we have a bug for it?

ronso0 · 2018-09-20T12:17:48Z

Edit I don't recall this ~~happened with this PR only,~~ happening with master for a few months I think, so No there's no bug report.

ronso0 · 2018-09-20T13:24:28Z

I will test this in master again to be sure

Holzhaus · 2019-11-25T23:57:36Z

Hey, #1367 has been merged in the meantime. What's the status of this? Can you resolve the merge conflicts?

Be-ing · 2019-11-26T12:08:20Z

@Holzhaus I have no plans to work on this soon. If you want to finish it, please go ahead.

Holzhaus · 2019-11-26T17:57:33Z

Is there anything else to be done except fixing the merge conflicts?

github-actions · 2020-10-20T00:22:18Z

This PR is marked as stale because it has been open 90 days with no activity.

do not adjust beatloop_size when pressing beatlooproll_X_activate

6a75237

daschuer requested changes Dec 20, 2017

View reviewed changes

Be-ing added 2 commits December 20, 2017 20:49

add clarifying comment

1b8a7e6

ensure active beatloop button is cleared when appropriate

40dfb09

Be-ing added this to the 2.1.0 milestone Dec 27, 2017

daschuer modified the milestones: 2.1.0, 2.2.0 Mar 22, 2018

Be-ing modified the milestones: 2.2.0, 2.3.0 Jun 23, 2018

ronso0 mentioned this pull request Sep 19, 2018

allow for overlapping beatlooprolls #1812

Merged

Be-ing modified the milestones: 2.3.0, stalled Feb 7, 2019

github-actions Bot added the stale Stale issues that haven't been updated for a long time. label Oct 20, 2020

Be-ing changed the base branch from master to main October 23, 2020 23:52

Be-ing marked this pull request as draft December 8, 2020 07:48

Be-ing closed this Dec 8, 2020

This was referenced Aug 23, 2022

rolling beatloop shouldn't alter beatloop size in spinbox #8947

Closed

Loop Cancels When Pressing Play #9076

Closed

Uh oh!

Conversation

Be-ing commented Dec 20, 2017

Uh oh!

daschuer Dec 20, 2017

Choose a reason for hiding this comment

Uh oh!

Be-ing Dec 20, 2017

Choose a reason for hiding this comment

Uh oh!

daschuer Dec 20, 2017

Choose a reason for hiding this comment

Uh oh!

Be-ing Dec 20, 2017

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Dec 21, 2017

Uh oh!

Be-ing commented Dec 21, 2017

Uh oh!

ronso0 commented Dec 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Dec 22, 2017

Uh oh!

Be-ing commented Dec 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daschuer commented Dec 22, 2017

Uh oh!

daschuer commented Dec 22, 2017

Uh oh!

daschuer commented Mar 22, 2018

Uh oh!

daschuer commented Sep 20, 2018

Uh oh!

ronso0 commented Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Sep 20, 2018

Uh oh!

Holzhaus commented Nov 25, 2019

Uh oh!

Be-ing commented Nov 26, 2019

Uh oh!

Holzhaus commented Nov 26, 2019

Uh oh!

github-actions Bot commented Oct 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ronso0 commented Dec 21, 2017 •

edited

Loading

Be-ing commented Dec 22, 2017 •

edited

Loading

ronso0 commented Sep 20, 2018 •

edited

Loading